Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blind_spot): devide scene into Categories and act accordingly #7110

Merged
merged 2 commits into from
May 27, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 24, 2024

Description

categorize the scene into

  • InternalError
  • OverPassJudge
  • Unsafe
  • Safe
    and act according to RTC and that scene respectively.

Related links

Tests performed

https://evaluation.tier4.jp/evaluation/reports/089988e0-7552-5c60-9fdc-a6dc6a157377?project_id=prd_jt

Notes for reviewers

Interface changes

none

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

soblin added 2 commits May 23, 2024 15:50
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin requested review from shmpwk and tkimura4 as code owners May 24, 2024 04:35
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 24, 2024
@shmpwk shmpwk requested a review from Ericpotato May 27, 2024 01:56
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 27, 2024
@Ericpotato
Copy link
Contributor

LGTM!

@soblin soblin merged commit 49f91a2 into autowarefoundation:main May 27, 2024
32 of 35 checks passed
@soblin soblin deleted the refactor/blind-spot branch May 27, 2024 05:35
soblin added a commit to tier4/autoware_universe that referenced this pull request May 29, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
#7110)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants