Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(twist2accel): componentize Twist2Accel #7101

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 23, 2024

Description

Componentize the node in localization/twist2accel.
(Add glog feature to localization/twist2accel)

Log output is changed from "screen" to "both".

Tests performed

confirmed that killing the twist2accel process will output logs to terminal and log file

1716458152.3169267 [twist2accel_node-43] [INFO] [1716458152.316553501] [rclcpp]: signal_handler(signum=15)
1716458152.3175087 [twist2accel_node-43] *** Aborted at 1716458152 (unix time) try "date -d @1716458152" if you are using GNU date ***
1716458152.3178585 [twist2accel_node-43] PC: @                0x0 (unknown)
1716458152.3179154 [twist2accel_node-43] *** SIGTERM (@0x3e8001c1f43) received by PID 1213591 (TID 0x7f3bcbe7a680) from PID 1843011; stack trace: ***
1716458152.3182986 [twist2accel_node-43]     @     0x7f3bcc71f4d6 google::(anonymous namespace)::FailureSignalHandler()
1716458152.3186543 [twist2accel_node-43]     @     0x7f3bcc619ded rclcpp::SignalHandler::signal_handler()
1716458152.3189938 [twist2accel_node-43]     @     0x7f3bcbc42520 (unknown)
1716458152.3193457 [twist2accel_node-43]     @     0x7f3bcbc91117 (unknown)
1716458152.3193991 [twist2accel_node-43]     @     0x7f3bcbc93a41 pthread_cond_wait
1716458152.3194406 [twist2accel_node-43]     @     0x7f3bcbb16a8d ddsrt_cond_wait
1716458152.3194785 [twist2accel_node-43]     @     0x7f3bcbb16b55 ddsrt_cond_waituntil
1716458152.3195155 [twist2accel_node-43]     @     0x7f3bcbafd45d (unknown)
1716458152.3198261 [twist2accel_node-43]     @     0x7f3bcbbb974f rmw_wait
1716458152.3198802 [twist2accel_node-43]     @     0x7f3bcc360848 rcl_wait
1716458152.3202269 [twist2accel_node-43]     @     0x7f3bcc5611b6 rclcpp::Executor::wait_for_work()
1716458152.3205853 [twist2accel_node-43]     @     0x7f3bcc5616d3 rclcpp::Executor::get_next_executable()
1716458152.3209515 [twist2accel_node-43]     @     0x7f3bcc565c81 rclcpp::executors::SingleThreadedExecutor::spin()
1716458152.3210161 [twist2accel_node-43]     @     0x556178cd0486 main
1716458152.3210607 [twist2accel_node-43]     @     0x7f3bcbc29d90 (unknown)
1716458152.3214049 [twist2accel_node-43]     @     0x7f3bcbc29e40 __libc_start_main
1716458152.3214576 [twist2accel_node-43]     @     0x556178cd0e35 _start
1716458152.3227983 [ERROR] [twist2accel_node-43]: process has died

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

a-maumau added 2 commits May 23, 2024 12:59
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 23, 2024
a-maumau added 2 commits May 24, 2024 09:52
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau changed the title feat(twist2accel): add glog to Twist2Accel feat(twist2accel): componentize Twist2Accel May 24, 2024
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the errors were properly logged to the file.
Thanks!

@SakodaShintaro SakodaShintaro enabled auto-merge (squash) May 24, 2024 01:18
@SakodaShintaro SakodaShintaro merged commit 2ac6116 into autowarefoundation:main May 24, 2024
35 of 37 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add and mod to use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* rm dependencies

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add and mod to use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* rm dependencies

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau deleted the mau/feat/localization/twist2accel branch July 22, 2024 06:17
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add and mod to use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* rm dependencies

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants