test(image_projection_based_fusion): add unit test code for geometry #7096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasatoSaeki
requested review from
badai-nguyen,
kminoda,
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
kminoda
added
the
run:build-and-test-differential
kminoda
reviewed
May 23, 2024
perception/image_projection_based_fusion/test/test_geometry.cpp
Outdated
Show resolved
Hide resolved
perception/image_projection_based_fusion/test/test_geometry.cpp
Outdated
Show resolved
Hide resolved
yukkysaito
reviewed
May 23, 2024
Comment on lines
140
to
141
| int height_ = 400; // image height | ||
| int width_ = 300; // image width |
There was a problem hiding this comment.
Suggested change
| int height_ = 400; // image height | |
| int width_ = 300; // image width | |
| int height = 400; // image height | |
| int width = 300; // image width |
There was a problem hiding this comment.
fixed in be2118e
…_based_fusion/test_vertices_points_inside_roi
…ices_points_inside_roi
|
@MasatoSaeki I forced the DCO CI passed. From next time please signoff for each github commit (by |
…ices_points_inside_roi
…_based_fusion/test_vertices_points_inside_roi
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…utowarefoundation#7096) * add geometry utility test code * style(pre-commit): autofix * fix scope and declare * change declare name * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…utowarefoundation#7096) * add geometry utility test code * style(pre-commit): autofix * fix scope and declare * change declare name * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
MasatoSaeki
deleted the
test/image_projection_based_fusion/test_vertices_points_inside_roi
branch
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…7096) * add geometry utility test code * style(pre-commit): autofix * fix scope and declare * change declare name * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit test for below in image_projection_basef_fusion package
objectToVerticesboundingBoxToVerticescylinderToVerticestransformPointsis_insidesanitizeROITests performed
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.