Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gyro_odometer): componentize node in gyro_odometer #7090

Conversation

Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented May 22, 2024

Description

Componentize node in gyro_odometer.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 22, 2024
@Motsu-san Motsu-san changed the title refactor(gyro_odometer): install glog to gyro_odometer refactor(gyro_odometer): componentize gyro_odometer node May 22, 2024
@Motsu-san Motsu-san changed the title refactor(gyro_odometer): componentize gyro_odometer node refactor(gyro_odometer): componentize node in gyro_odometer May 22, 2024
@Motsu-san Motsu-san marked this pull request as ready for review May 24, 2024 05:03
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the command

~/pilot-auto$ ps aux | grep gyro_odometer
shintar+  572710  3.7  0.1 846444 33472 pts/0    Sl+  14:34   0:00 /home/shintarosakoda/pilot-auto/install/gyro_odometer/lib/gyro_odometer/gyro_odometer_node --ros-args -r __ns:= ...
~/pilot-auto$ kill -15 572710

and I got

1716528934.3131347 [gyro_odometer_node-42] [INFO] [1716528934.312799370] [rclcpp]: signal_handler(signum=15)
1716528934.3132491 [gyro_odometer_node-42] *** Aborted at 1716528934 (unix time) try "date -d @1716528934" if you are using GNU date ***
1716528934.3218846 [gyro_odometer_node-42] PC: @                0x0 (unknown)
1716528934.3223274 [gyro_odometer_node-42] *** SIGTERM (@0x3e800050098) received by PID 572710 (TID 0x7f97e122c680) from PID 327832; stack trace: ***
1716528934.3226633 [gyro_odometer_node-42]     @     0x7f97e1cf24d6 google::(anonymous namespace)::FailureSignalHandler()
1716528934.3229954 [gyro_odometer_node-42]     @     0x7f97e1c28ded rclcpp::SignalHandler::signal_handler()
1716528934.3232925 [gyro_odometer_node-42]     @     0x7f97e1580520 (unknown)
1716528934.3235826 [gyro_odometer_node-42]     @     0x7f97e15cf117 (unknown)
1716528934.3238688 [gyro_odometer_node-42]     @     0x7f97e15d1a41 pthread_cond_wait
1716528934.3241611 [gyro_odometer_node-42]     @     0x7f97e1132a8d ddsrt_cond_wait
1716528934.3241920 [gyro_odometer_node-42]     @     0x7f97e1132b55 ddsrt_cond_waituntil
1716528934.3244286 [gyro_odometer_node-42]     @     0x7f97e111945d (unknown)
1716528934.3244598 [gyro_odometer_node-42]     @     0x7f97e11d574f rmw_wait
1716528934.3247356 [gyro_odometer_node-42]     @     0x7f97e14de848 rcl_wait
1716528934.3250237 [gyro_odometer_node-42]     @     0x7f97e1b701b6 rclcpp::Executor::wait_for_work()
1716528934.3254793 [gyro_odometer_node-42]     @     0x7f97e1b706d3 rclcpp::Executor::get_next_executable()
1716528934.3257730 [gyro_odometer_node-42]     @     0x7f97e1b74c81 rclcpp::executors::SingleThreadedExecutor::spin()
1716528934.3260114 [gyro_odometer_node-42]     @     0x5579c0747486 main
1716528934.3263249 [gyro_odometer_node-42]     @     0x7f97e1567d90 (unknown)
1716528934.3265641 [gyro_odometer_node-42]     @     0x7f97e1567e40 __libc_start_main
1716528934.3265944 [gyro_odometer_node-42]     @     0x5579c0747e35 _start

Looks Good To Me

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 15.10%. Comparing base (3d849e9) to head (e77370a).
Report is 45 commits behind head on main.

Files Patch % Lines
...alization/gyro_odometer/src/gyro_odometer_core.cpp 42.30% 0 Missing and 15 partials ⚠️
...n/gyro_odometer/test/test_gyro_odometer_pubsub.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7090      +/-   ##
==========================================
+ Coverage   15.09%   15.10%   +0.01%     
==========================================
  Files        1967     1967              
  Lines      135941   135717     -224     
  Branches    42122    42008     -114     
==========================================
- Hits        20520    20504      -16     
+ Misses      92700    92553     -147     
+ Partials    22721    22660      -61     
Flag Coverage Δ *Carryforward flag
differential 50.00% <39.28%> (?)
total 15.10% <ø> (+<0.01%) ⬆️ Carriedforward from 3d849e9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit 6d77841 into autowarefoundation:main May 24, 2024
39 of 42 checks passed
@Motsu-san Motsu-san deleted the refactor/install_glog_to_gyro_odometer branch May 27, 2024 00:35
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…foundation#7090)

* refactor: install glog to gyro_odometer

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

* style(pre-commit): autofix

* feat: change glog error setting

---------

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…foundation#7090)

* refactor: install glog to gyro_odometer

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

* style(pre-commit): autofix

* feat: change glog error setting

---------

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* refactor: install glog to gyro_odometer

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

* style(pre-commit): autofix

* feat: change glog error setting

---------

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants