Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freespace_planning_algorithms): Debug tools for Python wrapper of freespace planning algorithms #7068

remove unneccesary lines

4398978
Select commit
Loading
Failed to load commit list.
Closed

feat(freespace_planning_algorithms): Debug tools for Python wrapper of freespace planning algorithms #7068

remove unneccesary lines
4398978
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded May 20, 2024 in 38s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 5 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments common_classes.py: Result.init
  • Excess Number of Function Arguments visualize_trajectories.py: DrawClickedTrajectory.init
  • Bumpy Road Ahead search_gridgoal.py: float_range
  • Global Conditionals search_gridgoal.py
  • Global Conditionals visualize_trajectories.py

Annotations

Check warning on line 46 in planning/freespace_planning_algorithms/scripts/parameter_tuning_tools/search_gridgoal.py

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

float_range has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in planning/freespace_planning_algorithms/scripts/parameter_tuning_tools/search_gridgoal.py

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Global Conditionals

There's global code outside of functions with a cyclomatic complexity of 12, threshold = 10. The code has become too complex as it contains many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more.

Check warning on line 15 in planning/freespace_planning_algorithms/scripts/parameter_tuning_tools/common/common_classes.py

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

Result.__init__ has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 1 in planning/freespace_planning_algorithms/scripts/parameter_tuning_tools/visualize_trajectories.py

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Global Conditionals

There's global code outside of functions with a cyclomatic complexity of 11, threshold = 10. The code has become too complex as it contains many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more.

Check warning on line 45 in planning/freespace_planning_algorithms/scripts/parameter_tuning_tools/visualize_trajectories.py

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

DrawClickedTrajectory.__init__ has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.