fix(map_based_prediction): revert use different time horizon (#6877) #6970
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Improving Code Health: 6 findings(s) ✅
Details
✅ Improving Code Health:
- Lines of Code in a Single File map_based_prediction_node.cpp
- Large Method map_based_prediction_node.cpp: MapBasedPredictionNode::MapBasedPredictionNode
- Primitive Obsession path_generator.cpp
- Excess Number of Function Arguments path_generator.cpp: PathGenerator::generatePathForOnLaneVehicle
- Excess Number of Function Arguments path_generator.cpp: PathGenerator::generatePolynomialPath
- Excess Number of Function Arguments path_generator.cpp: PathGenerator::generateFrenetPath
Annotations
Check notice on line 1 in perception/map_based_prediction/src/map_based_prediction_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1778 to 1773, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 795 in perception/map_based_prediction/src/map_based_prediction_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Large Method
MapBasedPredictionNode::MapBasedPredictionNode decreases from 93 to 91 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 1 in perception/map_based_prediction/src/path_generator.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Primitive Obsession
The ratio of primivite types in function arguments is no longer above the threshold
Check notice on line 158 in perception/map_based_prediction/src/path_generator.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
PathGenerator::generatePathForOnLaneVehicle is no longer above the threshold for number of arguments
Check notice on line 205 in perception/map_based_prediction/src/path_generator.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
PathGenerator::generatePolynomialPath is no longer above the threshold for number of arguments
Check notice on line 217 in perception/map_based_prediction/src/path_generator.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
PathGenerator::generateFrenetPath is no longer above the threshold for number of arguments