Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): multi object input #6820

Merged

style(pre-commit): autofix

13adc73
Select commit
Loading
Failed to load commit list.
Merged

feat(multi_object_tracker): multi object input #6820

style(pre-commit): autofix
13adc73
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed May 23, 2024 in 41s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 14 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method debug_object.cpp: TrackerObjectDebugger::draw
  • Bumpy Road Ahead debug_object.cpp: TrackerObjectDebugger::draw
  • Overall Code Complexity debug_object.cpp
  • Deep, Nested Complexity debug_object.cpp: TrackerObjectDebugger::draw
  • Large Method big_vehicle_tracker.cpp: BigVehicleTracker::BigVehicleTracker
  • Large Method normal_vehicle_tracker.cpp: NormalVehicleTracker::NormalVehicleTracker
  • Large Method multi_object_tracker_core.cpp: MultiObjectTracker::MultiObjectTracker
  • Large Method bicycle_tracker.cpp: BicycleTracker::BicycleTracker
  • Large Method pedestrian_tracker.cpp: PedestrianTracker::PedestrianTracker
  • Large Method unknown_tracker.cpp: UnknownTracker::UnknownTracker
  • Excess Number of Function Arguments debug_object.cpp: TrackerObjectDebugger::collect
  • Excess Number of Function Arguments debugger.cpp: TrackerDebugger::collectObjectInfo
  • Complex Method input_manager.cpp: InputStream::updateTimingStatus
  • Bumpy Road Ahead input_manager.cpp: InputStream::updateTimingStatus

Annotations

Check warning on line 195 in perception/multi_object_tracker/src/multi_object_tracker_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

MultiObjectTracker::MultiObjectTracker has 93 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 147 in perception/multi_object_tracker/src/processor/input_manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

InputStream::updateTimingStatus has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 147 in perception/multi_object_tracker/src/processor/input_manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

InputStream::updateTimingStatus has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 57 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

BicycleTracker::BicycleTracker increases from 91 to 93 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 58 in perception/multi_object_tracker/src/tracker/model/big_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

BigVehicleTracker::BigVehicleTracker increases from 102 to 104 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 58 in perception/multi_object_tracker/src/tracker/model/normal_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

NormalVehicleTracker::NormalVehicleTracker increases from 102 to 104 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 57 in perception/multi_object_tracker/src/tracker/model/pedestrian_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

PedestrianTracker::PedestrianTracker increases from 85 to 87 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 51 in perception/multi_object_tracker/src/tracker/model/unknown_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

UnknownTracker::UnknownTracker increases from 76 to 78 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 192 in perception/multi_object_tracker/src/debugger/debugger.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

TrackerDebugger::collectObjectInfo has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 354 in perception/multi_object_tracker/src/debugger/debug_object.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

TrackerObjectDebugger::draw has a cyclomatic complexity of 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 354 in perception/multi_object_tracker/src/debugger/debug_object.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

TrackerObjectDebugger::draw has 5 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in perception/multi_object_tracker/src/debugger/debug_object.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 4.33 across 9 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 354 in perception/multi_object_tracker/src/debugger/debug_object.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

TrackerObjectDebugger::draw has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 131 in perception/multi_object_tracker/src/debugger/debug_object.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

TrackerObjectDebugger::collect has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.