Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sensing/image_transport_decompressor): rework parameters #6746

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Apr 4, 2024

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Apr 4, 2024
@oguzkaganozt oguzkaganozt self-assigned this Apr 4, 2024
@oguzkaganozt oguzkaganozt requested a review from yukkysaito as a code owner April 4, 2024 12:44
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.94%. Comparing base (3d849e9) to head (aad17c6).
Report is 177 commits behind head on main.

Current head aad17c6 differs from pull request most recent head 0818000

Please upload reports for the commit 0818000 to get more accurate results.

Files Patch % Lines
..._decompressor/src/image_transport_decompressor.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6746      +/-   ##
==========================================
- Coverage   15.09%   14.94%   -0.16%     
==========================================
  Files        1967     1944      -23     
  Lines      135941   134025    -1916     
  Branches    42122    39867    -2255     
==========================================
- Hits        20520    20024     -496     
+ Misses      92700    91711     -989     
+ Partials    22721    22290     -431     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.94% <ø> (-0.16%) ⬇️ Carriedforward from 41aab51

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knzo25 knzo25 self-requested a review April 26, 2024 07:58
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay 🙇
LGTM

@oguzkaganozt oguzkaganozt merged commit 9fd6d55 into main Jun 10, 2024
24 of 25 checks passed
@oguzkaganozt oguzkaganozt deleted the refactor/image_transport_decompressor branch June 10, 2024 10:15
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
)

* add param, schema file, update readme

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants