fix(object_recognition_utils): check polygon area on iou calculation #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
requested review from
scepter914,
miursh,
takayuki5168 and
YoshiRi
as code owners
github-actions
bot
added
the
component:common
|
Dear @mebasoglu, Can you test it with the data you have? |
|
Hello @technolojin , I have tested with our data and confirmed that it works 👍. Thank you. |
technolojin
changed the title
technolojin
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
==========================================
+ Coverage 14.94% 14.95% +0.01%
==========================================
Files 1939 1936 -3
Lines 133673 133576 -97
Branches 39756 39758 +2
==========================================
Hits 19971 19971
+ Misses 91456 91353 -103
- Partials 22246 22252 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@scepter914 Can I request to review this PR? |
scepter914
approved these changes
Apr 2, 2024
This was referenced Apr 3, 2024
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Apr 5, 2024
…utowarefoundation#6701) * feat(object_recognition_utils): check input polygon on IoU calculations Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: MIN_AREA close to the epsilon of float 1e-6 Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…utowarefoundation#6701) * feat(object_recognition_utils): check input polygon on IoU calculations Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: MIN_AREA close to the epsilon of float 1e-6 Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a issue reported by @mebasoglu
ISSUE #6617
This PR is alternative of PR #6618.
Tests performed
Effects on system behavior
Prevent divide by zero on IoU calculation even abnormal objects size are come.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.