Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pointcloud_preprocessor): move roi_mode_map_ definition inside DualReturnOutlierFilterComponent class #6654

Merged
merged 1 commit into from
Mar 20, 2024
Merged

refactor(pointcloud_preprocessor): move roi_mode_map_ definition inside DualReturnOutlierFilterComponent class #6654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...sor/include/pointcloud_preprocessor/outlier_filter/dual_return_outlier_filter_nodelet.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@ namespace pointcloud_preprocessor
using diagnostic_updater::DiagnosticStatusWrapper;
using diagnostic_updater::Updater;

std::unordered_map<std::string, uint8_t> roi_mode_map_ = {
{"No_ROI", 0},
{"Fixed_xyz_ROI", 1},
{"Fixed_azimuth_ROI", 2},
};

class DualReturnOutlierFilterComponent : public pointcloud_preprocessor::Filter
{
protected:
Expand Down Expand Up @@ -86,6 +80,12 @@ class DualReturnOutlierFilterComponent : public pointcloud_preprocessor::Filter
float max_azimuth_deg_;
float max_distance_;

std::unordered_map<std::string, uint8_t> roi_mode_map_ = {
{"No_ROI", 0},
{"Fixed_xyz_ROI", 1},
{"Fixed_azimuth_ROI", 2},
};

public:
PCL_MAKE_ALIGNED_OPERATOR_NEW
explicit DualReturnOutlierFilterComponent(const rclcpp::NodeOptions & options);
Expand Down
Loading