feat(occupancy grid map): approximate extract common pointcloud function #6593
+145
−2
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 11, 2024 in 30s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Large Method utils.cpp: extractApproximateCommonPointCloud
- Bumpy Road Ahead utils.cpp: extractApproximateCommonPointCloud
Annotations
Check warning on line 322 in perception/probabilistic_occupancy_grid_map/src/utils/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
extractApproximateCommonPointCloud has 80 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 322 in perception/probabilistic_occupancy_grid_map/src/utils/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
extractApproximateCommonPointCloud has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading