Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(perception_online_evaluator): add lanelet2_extension dependency #6592

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Mar 11, 2024

Description

This PR adds a dependency to lanelet2_extension to fix a missing include.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Sorry, something went wrong.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thanks!!

@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 11, 2024
@esteve esteve enabled auto-merge (squash) March 11, 2024 16:06
@esteve
Copy link
Contributor Author

esteve commented Mar 11, 2024

@kosuke55 no problem, thanks for the quick review 🙂

@esteve esteve force-pushed the fix-lanelet-dependency branch from 8cd8c90 to 9517cac Compare March 11, 2024 16:07
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the fix-lanelet-dependency branch from 9517cac to fa73327 Compare March 11, 2024 16:08
@esteve esteve changed the title build(perception_online_evaluator): add lanelet_extension dependency build(perception_online_evaluator): add lanelet2_extension dependency Mar 11, 2024
@esteve esteve merged commit 5adc394 into main Mar 11, 2024
23 checks passed
@esteve esteve deleted the fix-lanelet-dependency branch March 11, 2024 16:24
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.80%. Comparing base (8bdb542) to head (fa73327).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6592   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1915     1915           
  Lines      132245   132237    -8     
  Branches    39317    39317           
=======================================
  Hits        19576    19576           
+ Misses      90838    90830    -8     
  Partials    21831    21831           
Flag Coverage Δ *Carryforward flag
differential 47.86% <ø> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from 8bdb542

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…6592)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…utowarefoundation#6592)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request Apr 23, 2024

Verified

This commit was signed with the committer’s verified signature.
badai-nguyen badai nguyen
…utowarefoundation#6592)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request Apr 23, 2024

Verified

This commit was signed with the committer’s verified signature.
badai-nguyen badai nguyen
…utowarefoundation#6592)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request May 9, 2024

Verified

This commit was signed with the committer’s verified signature.
badai-nguyen badai nguyen
…utowarefoundation#6592)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants