Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(centerpoint, pointpainting): rearrange parameters for ML models and packages #6591

Merged
merged 26 commits into from
Apr 26, 2024

chore: temporary remove schema required

70f4388
Select commit
Loading
Failed to load commit list.
Merged

refactor(centerpoint, pointpainting): rearrange parameters for ML models and packages #6591

chore: temporary remove schema required
70f4388
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Apr 26, 2024 in 46s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method node.cpp: LidarCenterPointNode::LidarCenterPointNode

Annotations

Check warning on line 86 in perception/lidar_centerpoint/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

LidarCenterPointNode::LidarCenterPointNode increases from 86 to 88 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis