Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(emergency_handler, mrm_handler) change MRM operators to classes inside Handler Nodes #6589

Closed
wants to merge 14 commits into from

style(pre-commit): autofix

9280b2d
Select commit
Loading
Failed to load commit list.
Closed

refactor(emergency_handler, mrm_handler) change MRM operators to classes inside Handler Nodes #6589

style(pre-commit): autofix
9280b2d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 13, 2024 in 36s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication emergency_handler_core.cpp

Annotations

Check warning on line 143 in system/emergency_handler/src/emergency_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication 

The module contains 2 functions with similar structure: EmergencyHandler::callMrmBehavior,EmergencyHandler::cancelMrmBehavior. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
View more details on CodeScene Delta Analysis