Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(image_projection_based_fusion): rename template argument #6583

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Mar 11, 2024

Description

Rename ambiguous template argument, from Msg to TargetMsg3D.

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 11, 2024
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 14.75%. Comparing base (70bdf7f) to head (f9044f7).
Report is 1 commits behind head on main.

Files Patch % Lines
.../image_projection_based_fusion/src/fusion_node.cpp 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6583      +/-   ##
==========================================
- Coverage   14.79%   14.75%   -0.05%     
==========================================
  Files        1915     1917       +2     
  Lines      132319   132133     -186     
  Branches    39332    39224     -108     
==========================================
- Hits        19576    19494      -82     
+ Misses      90907    90835      -72     
+ Partials    21836    21804      -32     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.75% <ø> (-0.04%) ⬇️ Carriedforward from 7aca16d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda marked this pull request as ready for review March 11, 2024 04:16
@kminoda
Copy link
Contributor Author

kminoda commented Mar 11, 2024

@tzhong518 Hi, would you review this PR?

Copy link
Contributor

@tzhong518 tzhong518 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 6c75c7b into autowarefoundation:main Mar 29, 2024
21 of 25 checks passed
@kminoda kminoda deleted the refactor/image_projection_based_fusion/rename_template_argument branch March 29, 2024 10:15
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…towarefoundation#6583)

* refactor(image_projection_based_fusion): rename template argument

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants