-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(image_projection_based_fusion): rename template argument #6583
refactor(image_projection_based_fusion): rename template argument #6583
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6583 +/- ##
==========================================
- Coverage 14.79% 14.75% -0.05%
==========================================
Files 1915 1917 +2
Lines 132319 132133 -186
Branches 39332 39224 -108
==========================================
- Hits 19576 19494 -82
+ Misses 90907 90835 -72
+ Partials 21836 21804 -32
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…e_template_argument
@tzhong518 Hi, would you review this PR? |
…e_template_argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…towarefoundation#6583) * refactor(image_projection_based_fusion): rename template argument Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Rename ambiguous template argument, from
Msg
toTargetMsg3D
.Tests performed
Not applicable
Effects on system behavior
Not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.