chore(imu_corrector): relax gyro bias threshold parameter #6582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmpwk
requested review from
kminoda,
TaikiYamada4 and
YamatoAndo
as code owners
github-actions
bot
added
the
component:sensing
There was a problem hiding this comment.
@shmpwk
The change itself seems fine, but your commit doesn't have your signature.
(DCO requirement failed)
shmpwk
added
the
run:build-and-test-differential
|
@TaikiYamada4 Thank you, I've fixed it. |
TaikiYamada4
approved these changes
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6582 +/- ##
=======================================
Coverage 14.77% 14.77%
=======================================
Files 1917 1917
Lines 132319 132319
Branches 39298 39298
=======================================
Hits 19552 19552
Misses 90941 90941
Partials 21826 21826
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…undation#6582) Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
shmpwk
added a commit
to tier4/autoware_universe
that referenced
this pull request
Mar 28, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because the current gyro bias threshold is too severe to most gyro sensors, this PR relaxes it.
TIER IV internal ticket
Tests performed
Tested this parameter on our product.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.