refactor(pointcloud_preprocessor): publish noise points in ring outlier filter #6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
kyoichi-sugahara
requested review from
amc-nu,
badai-nguyen,
miursh and
yukkysaito
as code owners
yukkysaito
reviewed
Mar 13, 2024
yukkysaito
reviewed
Mar 13, 2024
sensing/pointcloud_preprocessor/src/outlier_filter/ring_outlier_filter_nodelet.cpp
Outdated
Show resolved
Hide resolved
- Removed the `extractExcludedPoints` function - Defined `setUpPointCloudFormat` to consolidate duplicate processes - Renamed `horizontal_res` to `horizontal_resolution`. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
force-pushed
the
refactor/publish_noise_points_in_ring_outlier_filter
branch
from
c75e1f7 to
cf1177c
Compare
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
force-pushed
the
refactor/publish_noise_points_in_ring_outlier_filter
branch
from
cf1177c to
d85eabb
Compare
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
badai-nguyen
approved these changes
Mar 13, 2024
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6581 +/- ##
==========================================
- Coverage 14.79% 14.79% -0.01%
==========================================
Files 1915 1915
Lines 132361 132368 +7
Branches 39339 39339
==========================================
Hits 19581 19581
- Misses 90946 90953 +7
Partials 21834 21834
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
merged commit 283ff47
into
autowarefoundation:main
36 of 39 checks passed
kyoichi-sugahara
deleted the
refactor/publish_noise_points_in_ring_outlier_filter
branch
yhisaki
pushed a commit
to yhisaki/autoware.universe
that referenced
this pull request
Mar 15, 2024
…er filter (autowarefoundation#6581) * - Renamed the `publish_excluded_points` flag to `publish_noise_points`. - Removed the `extractExcludedPoints` function - Defined `setUpPointCloudFormat` to consolidate duplicate processes - Renamed `horizontal_res` to `horizontal_resolution`. * change from publish_noise_points to publish_outlier_pointcloud * change namespace of topic Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…er filter (autowarefoundation#6581) * - Renamed the `publish_excluded_points` flag to `publish_noise_points`. - Removed the `extractExcludedPoints` function - Defined `setUpPointCloudFormat` to consolidate duplicate processes - Renamed `horizontal_res` to `horizontal_resolution`. * change from publish_noise_points to publish_outlier_pointcloud * change namespace of topic Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…er filter (autowarefoundation#6581) * - Renamed the `publish_excluded_points` flag to `publish_noise_points`. - Removed the `extractExcludedPoints` function - Defined `setUpPointCloudFormat` to consolidate duplicate processes - Renamed `horizontal_res` to `horizontal_resolution`. * change from publish_noise_points to publish_outlier_pointcloud * change namespace of topic Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor for the PR
publish_excluded_pointsflag topublish_noise_points.extractExcludedPointsfunctionsetUpPointCloudFormatto consolidate duplicate processeshorizontal_restohorizontal_resolution.Tests performed
confirmed with logging simulator
How to check this feature
described in the PR
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.