Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_metrics_rviz_plugin): add selected metrics view tab #6577

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Mar 9, 2024

Description

add selected metrics view tab

metrics_viz-2024-03-09_15.19.12.mp4

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Sorry, something went wrong.

@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Mar 9, 2024
@kosuke55 kosuke55 force-pushed the feat/metrics_viz_selected_topic branch from 4baf683 to a027450 Compare March 9, 2024 06:26
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 14.76%. Comparing base (aa84a5e) to head (a027450).
Report is 2 commits behind head on main.

Files Patch % Lines
...etrics_rviz_plugin/src/metrics_visualize_panel.cpp 0.00% 67 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6577      +/-   ##
==========================================
- Coverage   14.78%   14.76%   -0.02%     
==========================================
  Files        1917     1918       +1     
  Lines      132253   132374     +121     
  Branches    39297    39297              
==========================================
  Hits        19550    19550              
- Misses      90876    90997     +121     
  Partials    21827    21827              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from aa84a5e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
confirmed gui works properly in my environment
image

@kosuke55 kosuke55 merged commit e2aee50 into autowarefoundation:main Mar 10, 2024
30 of 32 checks passed
@kosuke55 kosuke55 deleted the feat/metrics_viz_selected_topic branch March 10, 2024 11:58
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
badai-nguyen pushed a commit to tier4/autoware_universe that referenced this pull request May 9, 2024

Verified

This commit was signed with the committer’s verified signature.
badai-nguyen badai nguyen
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants