Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_based_prediction, etc): publish processing time in various perception nodes #6574

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Mar 8, 2024

Description

I added debug topic publisher in following packages:

  • map_based_prediction
  • tracking_object_merger
  • object_merger
  • shape_estimation
  • detection_by_tracker
  • radar_object_tracker

Those package will publish

  • cyclic time: elapsed time per one callback cycle
  • processing time: calculation time from the callback beginning to end

Related links

Tests performed

Tested with Lsim.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

YoshiRi added 6 commits March 8, 2024 14:57
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Mar 8, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 12, 2024
@YoshiRi YoshiRi enabled auto-merge (squash) March 12, 2024 01:34
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 15.08%. Comparing base (86b4335) to head (63e2167).
Report is 95 commits behind head on main.

Files Patch % Lines
..._tracker/include/detection_by_tracker/debugger.hpp 0.00% 14 Missing ⚠️
...based_prediction/src/map_based_prediction_node.cpp 0.00% 9 Missing ⚠️
...ject_merger/src/object_association_merger/node.cpp 0.00% 9 Missing ⚠️
perception/shape_estimation/src/node.cpp 0.00% 9 Missing ⚠️
...ng_object_merger/src/decorative_tracker_merger.cpp 0.00% 9 Missing ⚠️
...ction_by_tracker/src/detection_by_tracker_core.cpp 0.00% 1 Missing ⚠️
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6574      +/-   ##
==========================================
- Coverage   15.09%   15.08%   -0.01%     
==========================================
  Files        1823     1823              
  Lines      126342   126423      +81     
  Branches    38200    38200              
==========================================
  Hits        19077    19077              
- Misses      85871    85952      +81     
  Partials    21394    21394              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.10% <ø> (+<0.01%) ⬆️ Carriedforward from 86b4335

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi YoshiRi merged commit 1de37a3 into autowarefoundation:main Mar 12, 2024
30 of 33 checks passed
technolojin added a commit to tier4/autoware_universe that referenced this pull request Mar 18, 2024
…erception nodes (autowarefoundation#6574)

* feat: fix processing time publisher

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing_time in detection_by_tracker

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing time publisher to shape estimator

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add latency time for association merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing time publisher for tracker merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: rename pipeline latency in multi object tracker

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…erception nodes (autowarefoundation#6574)

* feat: fix processing time publisher

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing_time in detection_by_tracker

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing time publisher to shape estimator

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add latency time for association merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing time publisher for tracker merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: rename pipeline latency in multi object tracker

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…erception nodes (autowarefoundation#6574)

* feat: fix processing time publisher

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing_time in detection_by_tracker

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing time publisher to shape estimator

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add latency time for association merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add processing time publisher for tracker merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: rename pipeline latency in multi object tracker

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants