fix(avoidance): ignore objects are in intersection when the ego stops by red traffic signal #6565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
…ic light Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
fix/filter-by-red-signal
branch
from
e8b218a to
4208a72
Compare
satoshi-ota
requested review from
rej55,
kyoichi-sugahara,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
satoshi-ota
changed the title
shmpwk
approved these changes
Mar 11, 2024
shmpwk
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6565 +/- ##
=======================================
Coverage 14.78% 14.79%
=======================================
Files 1917 1917
Lines 132211 132217 +6
Branches 39297 39300 +3
=======================================
+ Hits 19552 19555 +3
- Misses 90833 90834 +1
- Partials 21826 21828 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
… by red traffic signal (#6565) fix(avoidance): don't avoid objects are farther than red signal traffic light Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 19, 2024
… by red traffic signal (autowarefoundation#6565) fix(avoidance): don't avoid objects are farther than red signal traffic light Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
… by red traffic signal (autowarefoundation#6565) fix(avoidance): don't avoid objects are farther than red signal traffic light Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 28, 2024
… by red traffic signal (autowarefoundation#6565) fix(avoidance): don't avoid objects are farther than red signal traffic light Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
… by red traffic signal (autowarefoundation#6565) fix(avoidance): don't avoid objects are farther than red signal traffic light Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, the avoidance modue generate unnecessary avoidance path for objects which are in intersection even when the ego stops by red traffic signal.
Related PR: https://tier4.atlassian.net/browse/RT1-5365
In this PR, I fixed detection range so that the module can ignore unrelated object.
Traffic light: RED -> Ignore objects are in intersection
Traffic light: GREEN -> Check objects are in intersection
Tests performed
Effects on system behavior
Improve avoidance behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.