-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(json-schema-check): run only if relevant files are changed #6530
Merged
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
52f586c
to
c091d5a
Compare
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
No files changed, skipped, successful. Schema files changed to fail the json-schema-check, failure (as expected). Schema files changed to succeed the json-schema-check, success. |
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
HansRobo
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
* ci(json-schema-check): run only if relevant files are changed Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * simplify Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * temp change to break things to test the action Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * temp change to test success of the action Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * revert temp changes Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * better naming Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> --------- Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…refoundation#6530) * ci(json-schema-check): run only if relevant files are changed Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * simplify Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * temp change to break things to test the action Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * temp change to test success of the action Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * revert temp changes Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * better naming Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> --------- Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…refoundation#6530) * ci(json-schema-check): run only if relevant files are changed Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * simplify Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * temp change to break things to test the action Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * temp change to test success of the action Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * revert temp changes Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> * better naming Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> --------- Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation from:
With this restructuring of the actions,
pre-check
will check if relevant files are changedjson-schema-check
will do its thingno-relevant-changes
will return successfulTests performed
Tests are below:
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.