Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): additional debug markers #6529

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Adding additional debug marker for lane change module

  • visualize current, target, backward target lanes
  • visualize distances metrics
  • visualize some of the reasons

Screenshot from 2024-03-01 17-51-13

image

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 1, 2024
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 1.38889% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 14.93%. Comparing base (badd949) to head (2eab43b).
Report is 2 commits behind head on main.

Files Patch % Lines
...ing/behavior_path_lane_change_module/src/scene.cpp 0.00% 30 Missing ⚠️
...vior_path_lane_change_module/src/utils/markers.cpp 0.00% 28 Missing ⚠️
...or_path_lane_change_module/utils/debug_structs.hpp 0.00% 9 Missing ⚠️
...behavior_path_lane_change_module/src/interface.cpp 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6529      +/-   ##
==========================================
- Coverage   14.94%   14.93%   -0.01%     
==========================================
  Files        1939     1939              
  Lines      133673   133733      +60     
  Branches    39756    39772      +16     
==========================================
- Hits        19971    19970       -1     
- Misses      91456    91517      +61     
  Partials    22246    22246              
Flag Coverage Δ *Carryforward flag
differential 8.15% <1.38%> (?)
total 14.94% <ø> (+<0.01%) ⬆️ Carriedforward from badd949

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat-lc-additional-debug-marker branch from 1dc2a0e to fb83190 Compare March 21, 2024 02:00
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat-lc-additional-debug-marker branch from fb83190 to 2eab43b Compare April 1, 2024 04:36
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 42d4936 into autowarefoundation:main Apr 1, 2024
25 of 28 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat-lc-additional-debug-marker branch April 1, 2024 06:18
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants