Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ndt_scan_matcher): refactor NDT map update #6505

Merged
merged 5 commits into from
Mar 5, 2024

Merge branch 'main' into feature/parallel_ndt_build

caa454e
Select commit
Loading
Failed to load commit list.
Merged

chore(ndt_scan_matcher): refactor NDT map update #6505

Merge branch 'main' into feature/parallel_ndt_build
caa454e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Mar 5, 2024 in 40s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Complex Method map_update_module.cpp: MapUpdateModule::update_ndt

Annotations

Check notice on line 162 in localization/ndt_scan_matcher/src/map_update_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method 

MapUpdateModule::update_ndt decreases in cyclomatic complexity from 10 to 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis