fix(avoidance): fix bug in minimum overhang distance calculation #6372
+29
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
satoshi-ota
force-pushed
the
fix/invalid-overhang-distance
branch
from
640a9c6 to
4e07804
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
requested review from
rej55,
kyoichi-sugahara,
shmpwk,
TakaHoribe,
TomohitoAndo and
tkimura4
as code owners
satoshi-ota
force-pushed
the
fix/invalid-overhang-distance
branch
from
4e07804 to
56281d8
Compare
satoshi-ota
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6372 +/- ##
==========================================
- Coverage 14.88% 14.88% -0.01%
==========================================
Files 1838 1838
Lines 126709 126717 +8
Branches 38044 38049 +5
==========================================
Hits 18863 18863
- Misses 86546 86554 +8
Partials 21300 21300
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shmpwk
pushed a commit
to tier4/autoware_universe
that referenced
this pull request
Feb 13, 2024
…owarefoundation#6372) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to tier4/autoware_universe
that referenced
this pull request
Feb 23, 2024
…owarefoundation#6372) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…owarefoundation#6372) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to tier4/autoware_universe
that referenced
this pull request
Mar 8, 2024
…owarefoundation#6372) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
TomohitoAndo
pushed a commit
to tier4/autoware_universe
that referenced
this pull request
Apr 1, 2024
…owarefoundation#6372) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to tier4/autoware_universe
that referenced
this pull request
Apr 8, 2024
…owarefoundation#6372) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…owarefoundation#6372) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The avoidance module judged wrong avoidable judge because it used unexpected overhang point to calculate road shoulder distance.
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.