Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): add acknowledgement for material icons in tool plugins #6354

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

KhalilSelyan
Copy link
Contributor

@KhalilSelyan KhalilSelyan commented Feb 7, 2024

Description

This is related to #6351 , needed to add notice but PR was already closed so this one has been opened to continue the rest of it

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

KhalilSelyan added 6 commits February 7, 2024 14:10
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
@KhalilSelyan KhalilSelyan requested a review from xmfcx February 7, 2024 15:39
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 7, 2024
@KhalilSelyan KhalilSelyan self-assigned this Feb 7, 2024
@KhalilSelyan KhalilSelyan added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ui-ux User interface, user experience, graphical user interfaces. labels Feb 7, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6df544) 14.86% compared to head (3e7d2eb) 14.86%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6354   +/-   ##
=======================================
  Coverage   14.86%   14.86%           
=======================================
  Files        1845     1845           
  Lines      126697   126659   -38     
  Branches    37883    37883           
=======================================
- Hits        18830    18828    -2     
+ Misses      86702    86665   -37     
- Partials    21165    21166    +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.86% <ø> (+<0.01%) ⬆️ Carriedforward from f646b2e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx xmfcx enabled auto-merge (squash) February 7, 2024 16:06
@xmfcx xmfcx disabled auto-merge February 8, 2024 08:29
@xmfcx xmfcx merged commit 444a73a into main Feb 8, 2024
24 checks passed
@xmfcx xmfcx deleted the update-autoware-tools-icons branch February 8, 2024 08:29
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned) type:ui-ux User interface, user experience, graphical user interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants