-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radar_crossing_objects_noise_filter): refactor CMakeLists #6263
fix(radar_crossing_objects_noise_filter): refactor CMakeLists #6263
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
I updated this branch to import #6278. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6263 +/- ##
==========================================
- Coverage 14.38% 14.38% -0.01%
==========================================
Files 1907 1907
Lines 129935 129935
Branches 37616 37616
==========================================
- Hits 18697 18695 -2
- Misses 90229 90230 +1
- Partials 21009 21010 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@scepter914 |
@miursh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…refoundation#6263) Signed-off-by: scepter914 <scepter914@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…refoundation#6263) Signed-off-by: scepter914 <scepter914@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Description
Refactor CMakeLists of
radar_crossing_objects_noise_filter
Tests performed
Checked by compile
Effects on system behavior
No
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.