Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_crossing_objects_noise_filter): refactor CMakeLists #6263

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Feb 1, 2024

Description

Refactor CMakeLists of radar_crossing_objects_noise_filter

Tests performed

Checked by compile

Effects on system behavior

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 1, 2024
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 1, 2024
@HansRobo
Copy link
Member

HansRobo commented Feb 1, 2024

I updated this branch to import #6278.
This will help you pass build-and-test-differential faster.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (742f44a) 14.38% compared to head (42142d7) 14.38%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6263      +/-   ##
==========================================
- Coverage   14.38%   14.38%   -0.01%     
==========================================
  Files        1907     1907              
  Lines      129935   129935              
  Branches    37616    37616              
==========================================
- Hits        18697    18695       -2     
- Misses      90229    90230       +1     
- Partials    21009    21010       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.38% <ø> (-0.01%) ⬇️ Carriedforward from 9687a49

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miursh
Copy link
Contributor

miursh commented Feb 6, 2024

@scepter914
Could you please let me know the reason for this change?

@scepter914
Copy link
Contributor Author

@miursh
Because the deleted code overlaps with autoware_cmake and it is unintentional duplication.
For now if autoware_cmake changes, it may work with unintended build options.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 49289b6 into autowarefoundation:main Feb 8, 2024
2 checks passed
@scepter914 scepter914 deleted the fix/refactor_radar_crossing_objects_noise_filter branch February 8, 2024 15:24
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…refoundation#6263)

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…refoundation#6263)

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants