Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(radar_object_tracker): move tracker config directory to parameter yaml #6250

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Jan 31, 2024

Description

Move launch parameter file description to yaml.

Warning

Need to fix autoware_launch first. autowarefoundation/autoware_launch#838

Tests performed

Build and test with lsim.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 31, 2024
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (488fca5) 14.84% compared to head (7f41f63) 14.85%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6250   +/-   ##
=======================================
  Coverage   14.84%   14.85%           
=======================================
  Files        1845     1845           
  Lines      126781   126781           
  Branches    37961    37961           
=======================================
+ Hits        18826    18828    +2     
+ Misses      86733    86732    -1     
+ Partials    21222    21221    -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.85% <ø> (+<0.01%) ⬆️ Carriedforward from 53590d5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit tracking.launch.xml in tier4_perception_launch so that object_recognition_tracking_radar_object_tracker_node_param_path is properly passed to the node. (Currently it doesn't)

Probably you should add an argument here:

    <!--radar long range dynamic object tracking-->
    <include file="$(find-pkg-share radar_object_tracker)/launch/radar_object_tracker.launch.xml">
      <arg name="input" value="$(var radar_tracker_input)"/>
      <arg name="output" value="$(var radar_tracker_output)"/>
      <arg name="data_association_matrix_path" value="$(var object_recognition_tracking_radar_object_tracker_data_association_matrix_param_path)"/>
      <arg name="tracker_setting_path" value="$(var object_recognition_tracking_radar_object_tracker_tracking_setting_param_path)"/>
    </include>

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi requested a review from miursh as a code owner February 9, 2024 01:12
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 9, 2024
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Feb 9, 2024

@kminoda
Thanks for you suggestion. Fixed here 7f41f63

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit a1d8321 into autowarefoundation:main Feb 9, 2024
23 of 24 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…er yaml (autowarefoundation#6250)

* chore: move tracker config directory to parameter yaml

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: add allow_substs to fix error

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: use radar tracking parameter from autoware_launch

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…er yaml (autowarefoundation#6250)

* chore: move tracker config directory to parameter yaml

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: add allow_substs to fix error

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: use radar tracking parameter from autoware_launch

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants