-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(radar_object_tracker): move tracker config directory to parameter yaml #6250
chore(radar_object_tracker): move tracker config directory to parameter yaml #6250
Conversation
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6250 +/- ##
=======================================
Coverage 14.84% 14.85%
=======================================
Files 1845 1845
Lines 126781 126781
Branches 37961 37961
=======================================
+ Hits 18826 18828 +2
+ Misses 86733 86732 -1
+ Partials 21222 21221 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please edit tracking.launch.xml in tier4_perception_launch so that object_recognition_tracking_radar_object_tracker_node_param_path
is properly passed to the node. (Currently it doesn't)
Probably you should add an argument here:
<!--radar long range dynamic object tracking-->
<include file="$(find-pkg-share radar_object_tracker)/launch/radar_object_tracker.launch.xml">
<arg name="input" value="$(var radar_tracker_input)"/>
<arg name="output" value="$(var radar_tracker_output)"/>
<arg name="data_association_matrix_path" value="$(var object_recognition_tracking_radar_object_tracker_data_association_matrix_param_path)"/>
<arg name="tracker_setting_path" value="$(var object_recognition_tracking_radar_object_tracker_tracking_setting_param_path)"/>
</include>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…er yaml (autowarefoundation#6250) * chore: move tracker config directory to parameter yaml Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: add allow_substs to fix error Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: use radar tracking parameter from autoware_launch Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
…er yaml (autowarefoundation#6250) * chore: move tracker config directory to parameter yaml Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: add allow_substs to fix error Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: use radar tracking parameter from autoware_launch Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Description
Move launch parameter file description to yaml.
Warning
Need to fix autoware_launch first. autowarefoundation/autoware_launch#838
Tests performed
Build and test with lsim.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.