Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(traffic_light_map_based_detector): rework parameters #6200

Original file line number Diff line number Diff line change
@@ -49,10 +49,12 @@
<push-ros-namespace namespace="detection"/>
<include file="$(find-pkg-share traffic_light_map_based_detector)/launch/traffic_light_map_based_detector.launch.xml">
<arg name="input/camera_info" value="$(var input/camera_info)"/>
<arg name="min_timestamp_offset" value="-0.3"/>
<arg name="expect/rois" value="expect/rois"/>
<arg name="output/rois" value="$(var map_based_detector_output_topic)"/>
<arg name="output/camera_info" value="camera_info"/>
<!-- This parameter should be configured differently for each camera considering their delay. -->
<arg name="min_timestamp_offset" value="-0.3"/>
<arg name="max_timestamp_offset" value="0.0"/>
</include>
</group>

@@ -106,10 +108,12 @@
<push-ros-namespace namespace="detection"/>
<include file="$(find-pkg-share traffic_light_map_based_detector)/launch/traffic_light_map_based_detector.launch.xml">
<arg name="input/camera_info" value="$(var input/camera_info)"/>
<arg name="min_timestamp_offset" value="-0.04"/>
<arg name="expect/rois" value="expect/rois"/>
<arg name="output/rois" value="$(var map_based_detector_output_topic)"/>
<arg name="output/camera_info" value="camera_info"/>
<!-- This parameter should be configured differently for each camera considering their delay. -->
<arg name="min_timestamp_offset" value="-0.3"/>
<arg name="max_timestamp_offset" value="0.0"/>
</include>
</group>

Original file line number Diff line number Diff line change
@@ -6,5 +6,6 @@
max_vibration_width: 0.5 # -0.25 ~ 0.25 m
max_vibration_depth: 0.5 # -0.25 ~ 0.25 m
max_detection_range: 200.0
timestamp_sample_len: 0.02
car_traffic_light_max_angle_range: 40.0
pedestrian_traffic_light_max_angle_range: 80.0
Original file line number Diff line number Diff line change
@@ -5,12 +5,6 @@
<arg name="input/route" default="/planning/mission_planning/route"/>
<arg name="expect/rois" default="~/expect/rois"/>
<arg name="output/rois" default="~/output/rois"/>
<arg name="output/camera_info" default="~/camera_info"/>
<!--This parameter should be configured differently for each camera considering their delay.-->
<arg name="min_timestamp_offset" default="0.0"/>
<!--This parameter should be configured differently for each camera considering their delay.-->
<arg name="max_timestamp_offset" default="0.0"/>
<arg name="timestamp_sample_len" default="0.02"/>
<arg name="param_path" default="$(find-pkg-share traffic_light_map_based_detector)/config/traffic_light_map_based_detector.param.yaml"/>

<node pkg="traffic_light_map_based_detector" exec="traffic_light_map_based_detector_node" name="traffic_light_map_based_detector" output="screen">
@@ -19,10 +13,6 @@
<remap from="~/expect/rois" to="$(var expect/rois)"/>
<remap from="~/input/route" to="$(var input/route)"/>
<remap from="~/output/rois" to="$(var output/rois)"/>
<remap from="~/output/camera_info" to="$(var output/camera_info)"/>
<param from="$(var param_path)"/>
<param name="min_timestamp_offset" value="$(var min_timestamp_offset)"/>
<param name="max_timestamp_offset" value="$(var max_timestamp_offset)"/>
<param name="timestamp_sample_len" value="$(var timestamp_sample_len)"/>
</node>
</launch>