Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mission_planner): correct checkpoint pose #6059

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mebasoglu
Copy link
Contributor

Description

This PR allows correcting checkpoint poses. Currently, we can only correct goal pose.

Related links

Issue: #6058

Tests performed

Tested on planning simulator. Here is a video of testing. Without specifying orientation to fit the footprint inside lanelet manually, it corrects the pose automatically.

mission_planner_correct_all.mp4

Notes for reviewers

Interface changes

Effects on system behavior

Enabling enable_correct_goal_pose parameter will make checkpoint poses be corrected along with the goal pose.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 11, 2024
@beyzanurkaya beyzanurkaya linked an issue Jan 17, 2024 that may be closed by this pull request
3 tasks
@mehmetdogru mehmetdogru added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 15, 2024
@mehmetdogru
Copy link
Contributor

@mebasoglu

Could you update your PR?
Also DCO seems to be failing please take a look

@mebasoglu mebasoglu force-pushed the correct-checkpoint-pose branch 2 times, most recently from ab3fba3 to 1a0eeae Compare February 15, 2024 10:57
@mebasoglu
Copy link
Contributor Author

Hello @mehmetdogru , I updated and fixed DCO.

@mehmetdogru mehmetdogru force-pushed the correct-checkpoint-pose branch from 1a0eeae to 0b0af70 Compare February 15, 2024 11:50
@mehmetdogru mehmetdogru added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 14.98%. Comparing base (35642a6) to head (0b0af70).
Report is 540 commits behind head on main.

Current head 0b0af70 differs from pull request most recent head 13a0ca5

Please upload reports for the commit 13a0ca5 to get more accurate results.

Files Patch % Lines
...n_planner/src/lanelet2_plugins/default_planner.cpp 25.00% 3 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6059      +/-   ##
==========================================
+ Coverage   14.93%   14.98%   +0.04%     
==========================================
  Files        1944     1839     -105     
  Lines      134061   127106    -6955     
  Branches    39891    38076    -1815     
==========================================
- Hits        20027    19051     -976     
+ Misses      91735    86739    -4996     
+ Partials    22299    21316     -983     
Flag Coverage Δ *Carryforward flag
differential 12.67% <25.00%> (?)
total 14.98% <ø> (+0.04%) ⬆️ Carriedforward from dcf38f9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mebasoglu mebasoglu force-pushed the correct-checkpoint-pose branch from 0b0af70 to e33cb7e Compare March 14, 2024 07:11
@mebasoglu mebasoglu requested a review from soblin as a code owner March 14, 2024 07:11
Signed-off-by: Mehmet Emin BAŞOĞLU <mehmeteminbasoglu@hotmail.com>
@mebasoglu mebasoglu force-pushed the correct-checkpoint-pose branch from e33cb7e to 13a0ca5 Compare April 16, 2024 11:41
Copy link

stale bot commented Jun 15, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 15, 2024
@mitsudome-r
Copy link
Member

@shulanbushangshu It would be nice if you can resolve the conflicts so that we can review it again.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 17, 2024
@shulanbushangshu
Copy link
Contributor

shulanbushangshu commented Dec 23, 2024

I studied the changes of code. Conflicts cannot be resolved directly in the web. Do I have permission to rebase directly.@mitsudome-r

@xmfcx
Copy link
Contributor

xmfcx commented Feb 4, 2025

@shulanbushangshu could you create a new PR for this change then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_correct_goal_pose doesn't correct checkpoints
5 participants