-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mission_planner): correct checkpoint pose #6059
base: main
Are you sure you want to change the base?
fix(mission_planner): correct checkpoint pose #6059
Conversation
Could you update your PR? |
ab3fba3
to
1a0eeae
Compare
Hello @mehmetdogru , I updated and fixed DCO. |
1a0eeae
to
0b0af70
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6059 +/- ##
==========================================
+ Coverage 14.93% 14.98% +0.04%
==========================================
Files 1944 1839 -105
Lines 134061 127106 -6955
Branches 39891 38076 -1815
==========================================
- Hits 20027 19051 -976
+ Misses 91735 86739 -4996
+ Partials 22299 21316 -983
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0b0af70
to
e33cb7e
Compare
Signed-off-by: Mehmet Emin BAŞOĞLU <mehmeteminbasoglu@hotmail.com>
e33cb7e
to
13a0ca5
Compare
This pull request has been automatically marked as stale because it has not had recent activity. |
@shulanbushangshu It would be nice if you can resolve the conflicts so that we can review it again. |
I studied the changes of code. Conflicts cannot be resolved directly in the web. Do I have permission to rebase directly.@mitsudome-r |
@shulanbushangshu could you create a new PR for this change then? |
Description
This PR allows correcting checkpoint poses. Currently, we can only correct goal pose.
Related links
Issue: #6058
Tests performed
Tested on planning simulator. Here is a video of testing. Without specifying orientation to fit the footprint inside lanelet manually, it corrects the pose automatically.
mission_planner_correct_all.mp4
Notes for reviewers
Interface changes
Effects on system behavior
Enabling
enable_correct_goal_pose
parameter will make checkpoint poses be corrected along with the goal pose.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.