fix(log-messages): reduce excessive log messages #5971
Merged
This check has been archived and is scheduled for deletion.
Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Feb 12, 2024 in 45s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Large Method lanelet2_map_visualization_node.cpp: Lanelet2MapVisualizationNode::onMapBin
- Complex Method scene.cpp: TrafficLightModule::modifyPathVelocity
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
Lanelet2MapVisualizationNode::onMapBin increases from 174 to 179 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 204 in planning/behavior_velocity_traffic_light_module/src/scene.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
TrafficLightModule::modifyPathVelocity already has high cyclomatic complexity, and now it increases in Lines of Code from 74 to 76. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading