refactor(perception-traffic-light-classifier): rework parameters #5797

karishma1911 · 2023-12-06T12:15:27Z

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the traffic-light-classifier

Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.

2.create schema

Tests performed

Not applicable.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

stale · 2024-03-19T18:59:59Z

This pull request has been automatically marked as stale because it has not had recent activity.

idorobotics · 2024-05-24T09:58:12Z

@miursh @yukkysaito please urgently review.

yukkysaito

Sorry for late.
LGTM

idorobotics · 2024-06-02T15:23:19Z

@karishma1911 could you rebase this to the latest main? To fix the CI.

…ort large maps (autowarefoundation#6725) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

…cloud_fusion (autowarefoundation#6840) * fix(image_projection_based_fusion): add intensity field for roi_pointcloud_fusion Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: revesve the cluster refinement Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: typo Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

…loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: Tomas Nagy <tomas@pmc.sk>

…ng flip (autowarefoundation#6881) * feat(perception_online_evaluator): imporve yaw rate metrics considering flip Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix test Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

…warefoundation#6398) * feat(freespace_planning_algorithms): add Astar search by python Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> * add copywrite and remove unneeded comment Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> * - Add method getWaypoints() into the astar class. - No need to convert to serial when user passes ros2 message to methods. Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> * insert astar python documents into the README Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> * trivial modification Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> * modify typo Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> * Update planning/freespace_planning_algorithms/scripts/bind/astar_search_pybind.cpp Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> * ad copyright Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> fix copyright Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> add copyright Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> * Update planning/freespace_planning_algorithms/scripts/bind/astar_search_pybind.cpp --------- Signed-off-by: Takumi Ito <takumi.ito@tier4.jp> Co-authored-by: Takumi Ito <takumi.ito@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

…ne (autowarefoundation#6879) style(pre-commit): autofix refactor: topic name Signed-off-by: Mehmet Emin BAŞOĞLU <mehmeteminbasoglu@hotmail.com>

…on#6889) rename ndt diag Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

…utowarefoundation#6875) * enable aeb, fix topic problem Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * eliminate unused var Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * enable aeb, fix topic problem Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * eliminate unused var Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add clustering method to eliminate small objects/noise Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove comments Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Crop points outside of EGO predicted path Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove offset Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Update library use Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add check for empty cloud Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add extra width for pointcloud cropping Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Use single PC ptr Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove problematic option Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Revert "Use single PC ptr" This reverts commit b5091fc. Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * refactoring Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Add back timestamp Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * consider all points in clusters Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * USe object hull to detect collisions Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Use only closest object point Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unused functions Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove debug timer out of code Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * make it so the clustering uses parameters Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * solve type problem Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update comment Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update README Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * eliminate member var in favor of local pointcloud ptr Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unused chrono dependency Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix(route_handler): add logger Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix indent Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

…tion#6743) * add param and schema file Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>

* feat(ndt_scan_matcher): remake diag Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * add latest_ndt_aling_service_best_score Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * check nullptr Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * add validate_distance_from_initial_to_result Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * rename Signed-off-by: yamato-ando <Yamato ANDO> * style(pre-commit): autofix * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * update readme Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * [WIP] udpate Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * [WIP] udpate Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * add is_need_rebuild Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * add image Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * remove unused func Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * update image Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * remove unused include Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * move code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * move code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix FIX ME Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * remove unused func Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * [WIP] update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * add diag for trigger node service Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * move code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * delete unused code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * udpate Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * delete RCLCPP message Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * update Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * rename diag Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * rename func Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * remove Transition condition to OK Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix table Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * update readme Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix order Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * remove diag prefix Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix readme Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * rename diag Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * remove unused code Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix double free Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * output to terminal Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> --------- Signed-off-by: yamato-ando <Yamato ANDO> Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: yamato-ando <Yamato ANDO> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…els and packages (autowarefoundation#6591) * refactor: lidar_centerpoint Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * refactor: pointpainting Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: fix launch Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: fix launch Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: rearrange params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: json-schema-check error Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: default param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * refactor: rename param file Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: typo Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: align centerpoint param namespace with pointpainting Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix(centerpoint): add schema json Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix(pointpainting): fix schema json typo Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * style(pre-commit): autofix * docs: update pointpainting fusion doc Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * docs: update lidar centerpoint doc Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: change omp param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix:change twist and variance to model params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: keep build_only in launch Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: schema check Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: temporary remove schema required Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…foundation#6901) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

…utowarefoundation#6766) fix(avoidance): check object moving distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…arefoundation#7187) * remove unusing main func Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * mod to componentize and use glog Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * change exec name and change log output from log to both Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…ts (autowarefoundation#7177) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>

…warefoundation#7183) * mod to componentize and use glog Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * change log output from screen to both Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * style(pre-commit): autofix * Update localization/pose_estimator_arbiter/CMakeLists.txt add namespace Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com> * remove unusing main func Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>

…tion#7192) * rename file name and mod to componentize and use glog Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * mod to componentize and use glog Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * change exec name and add log output both Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

…refoundation#7181) * refactor(start_planner): clarify condition of transition to success Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify flowchart Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add debug print Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change diag time_stamp Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix time now Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * rename variable Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

add log output Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

…ation#7200) change log output from screen to both Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

…tion#6289)

… departure check (autowarefoundation#7193) * add param for lane departure margin Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * json thing Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * docs Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * make separate param for lane departure margin expansion Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update docs Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

…ndation#7213) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

…ion#7208) * fix(yabloc): fix bug in capturing in lambda function Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

…utowarefoundation#7096) * add geometry utility test code * style(pre-commit): autofix * fix scope and declare * change declare name * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…tprint (autowarefoundation#7186) feat: filter unknown objects with its footprint Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat!: remove autoware_auto_geometry package Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * docs: remove autoware_auto_geometry package from docs Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> --------- Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

…ation#7206) reafctor multi_object_tracker Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

…#7199) Signed-off-by: Mohammadreza Mirdamadiyan <smrm6789@gmail.com>

…re_perception_rviz_plugin (autowarefoundation#7221) feat(autoware_auto_perception_rviz_plugin): rename package to autoware_perception_rviz_plugin Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

…ai/autoware.universe into traffic-light-classifier

codecov · 2024-06-03T06:12:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3d849e9) to head (19d04f5).
Report is 125 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #5797       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.10%     
==========================================
  Files        1967       3     -1964     
  Lines      135941     258   -135683     
  Branches    42122       0    -42122     
==========================================
- Hits        20520       0    -20520     
+ Misses      92700     258    -92442     
+ Partials    22721       0    -22721

Flag	Coverage Δ
differential	`0.00% <0.00%> (?)`
total	`?`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

karishma1911 · 2024-06-04T06:32:01Z

@karishma1911 could you rebase this to the latest main? To fix the CI.

Done!

idorobotics · 2024-06-17T10:02:46Z

@karishma1911 DCO checks are failing. Please rebase to main.

xmfcx · 2024-06-17T10:11:52Z

Also please for PRs in Autoware, check this checkbox:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

So we can do it when necessary.

mitsudome-r · 2024-06-20T14:33:39Z

@karishma1911 Could you make the change as @xmfcx requested?
There is something wrong with the commit log, and I would like to clean them up before merging.

karishma1911 requested review from miursh and yukkysaito as code owners December 6, 2023 12:15

github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 6, 2023

karishma1911 force-pushed the traffic-light-classifier branch from 4d8fd78 to 8f6a83d Compare December 6, 2023 12:16

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 19, 2024

xmfcx closed this Apr 19, 2024

xmfcx reopened this Apr 19, 2024

stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Apr 19, 2024

xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 19, 2024

yukkysaito approved these changes May 28, 2024

View reviewed changes

karishma1911 requested a review from tzhong518 as a code owner June 3, 2024 04:47

maxime-clem and others added 16 commits June 3, 2024 10:23

perf(behavior_path_planner_common): simplify turn signal loop to supp…

0b29e89

…ort large maps (autowarefoundation#6725) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

refactor(lane_change): fix logger (autowarefoundation#6873)

e39a518

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

revert: feat(global_parameter_loader): add gtest to global parameter …

7bdb41d

…loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a.

feat(learned_model): create package (autowarefoundation#6395)

f0d3813

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: Tomas Nagy <tomas@pmc.sk>

fix(tier4_perception_launch): change traffic light recognition pipeli…

1d950bf

…ne (autowarefoundation#6879) style(pre-commit): autofix refactor: topic name Signed-off-by: Mehmet Emin BAŞOĞLU <mehmeteminbasoglu@hotmail.com>

feat(system diags): rename diag of ndt scan matcher (autowarefoundati…

9ba1894

…on#6889) rename ndt diag Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

fix(lidar_centerpoint): add param file for centerpoint_tiny (autoware…

5acd5d6

…foundation#6901) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix(avoidance): fix bug in the logic to check object moving distance (a…

23aa1ec

…utowarefoundation#6766) fix(avoidance): check object moving distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

a-maumau and others added 24 commits June 3, 2024 10:23

feat(obstacle_cruise_planner)!: ignore to garze against unknwon objec…

74f1310

…ts (autowarefoundation#7177) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>

feat(diagnostic_graph_utils): componentize node (autowarefoundation#7189

65c6a36

) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

feat(dummy_diag_publisher): componentize node (autowarefoundation#7190)

0850eb4

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

fix(map_tf_generator): add log output (autowarefoundation#7197)

4def39e

add log output Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

fix(gnss_poser): change log output from screen to both (autowarefound…

b389ded

…ation#7200) change log output from screen to both Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

refactor(image_projection_based_fusion): rework param (autowarefounda…

566bfb6

…tion#6289)

feat(obstacle_avoidance_planner): use polling subscriber (autowarefou…

25a4ff1

…ndation#7213) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

feat(path_smoother): use polling subscriber (autowarefoundation#7214)

d62c45a

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

refactor(yabloc): use constexpr properly (autowarefoundation#7207)

dd35f52

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

fix(autoware_auto_common): nullptr_t (autowarefoundation#7212)

4a41269

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

feat(detected_object_validation): filter unknown objects with its foo…

931b9f9

…tprint (autowarefoundation#7186) feat: filter unknown objects with its footprint Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

refactor(multi_object_tracker): use constexpr properly (autowarefound…

0f0e8ea

…ation#7206) reafctor multi_object_tracker Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

fix(radar_tracks_noise_filter): update param_path (autowarefoundation…

0ca0bf7

…#7199) Signed-off-by: Mohammadreza Mirdamadiyan <smrm6789@gmail.com>

Merge branch 'traffic-light-classifier' of https://github.com/Interpl…

19d04f5

…ai/autoware.universe into traffic-light-classifier

karishma1911 closed this Jun 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(perception-traffic-light-classifier): rework parameters #5797

refactor(perception-traffic-light-classifier): rework parameters #5797

karishma1911 commented Dec 6, 2023 •

edited

Loading

stale bot commented Mar 19, 2024

idorobotics commented May 24, 2024

yukkysaito left a comment

idorobotics commented Jun 2, 2024

codecov bot commented Jun 3, 2024

karishma1911 commented Jun 4, 2024

idorobotics commented Jun 17, 2024

xmfcx commented Jun 17, 2024

mitsudome-r commented Jun 20, 2024

refactor(perception-traffic-light-classifier): rework parameters #5797

refactor(perception-traffic-light-classifier): rework parameters #5797

Conversation

karishma1911 commented Dec 6, 2023 • edited Loading

Description

Tests performed

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

stale bot commented Mar 19, 2024

idorobotics commented May 24, 2024

yukkysaito left a comment

Choose a reason for hiding this comment

idorobotics commented Jun 2, 2024

codecov bot commented Jun 3, 2024

Codecov Report

karishma1911 commented Jun 4, 2024

idorobotics commented Jun 17, 2024

xmfcx commented Jun 17, 2024

mitsudome-r commented Jun 20, 2024

karishma1911 commented Dec 6, 2023 •

edited

Loading