Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ground_segmentation): add omp parallel for #5791

Merge branch 'main' into fix/ground_segmentation_parallel

696d2c3
Select commit
Loading
Failed to load commit list.
Closed

fix(ground_segmentation): add omp parallel for #5791

Merge branch 'main' into fix/ground_segmentation_parallel
696d2c3
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 26, 2024 in 32s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scan_ground_filter_nodelet.cpp: ScanGroundFilterComponent::classifyPointCloudGridScan
  • Complex Method scan_ground_filter_nodelet.cpp: ScanGroundFilterComponent::classifyPointCloud

Annotations

Check warning on line 410 in perception/ground_segmentation/src/scan_ground_filter_nodelet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

ScanGroundFilterComponent::classifyPointCloudGridScan already has high cyclomatic complexity, and now it increases in Lines of Code from 109 to 112. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 514 in perception/ground_segmentation/src/scan_ground_filter_nodelet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

ScanGroundFilterComponent::classifyPointCloud already has high cyclomatic complexity, and now it increases in Lines of Code from 98 to 101. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in perception/ground_segmentation/src/scan_ground_filter_nodelet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 7.29 to 7.36, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.