Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrm_pull_over_manager): add pull over mrm #5634

Closed

style(pre-commit): autofix

7fa0cf5
Select commit
Loading
Failed to load commit list.
Closed

feat(mrm_pull_over_manager): add pull over mrm #5634

style(pre-commit): autofix
7fa0cf5
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Apr 4, 2024 in 42s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 3 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Deep, Nested Complexity mrm_pull_over_manager_core.cpp: get_all_following_and_left_lanelets
  • Bumpy Road Ahead emergency_goal_manager_core.cpp: EmergencyGoalManager::callSetMrmRoutePoints
  • Bumpy Road Ahead emergency_goal_manager_core.cpp: EmergencyGoalManager::callClearMrmRoute

Annotations

Check warning on line 99 in system/mrm_pull_over_manager/src/mrm_pull_over_manager/mrm_pull_over_manager_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

get_all_following_and_left_lanelets has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 116 in system/emergency_goal_manager/src/emergency_goal_manager_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

EmergencyGoalManager::callSetMrmRoutePoints has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 145 in system/emergency_goal_manager/src/emergency_goal_manager_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

EmergencyGoalManager::callClearMrmRoute has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.