Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pid_longitudinal_controller): change pid structure with respect to design #5080

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −13

fix(pid_longitudinal_controller): change pid structure with respect t…

4bf0b18
Select commit
Loading
Failed to load commit list.
Draft

fix(pid_longitudinal_controller): change pid structure with respect to design #5080

fix(pid_longitudinal_controller): change pid structure with respect t…
4bf0b18
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Feb 15, 2024 in 47s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

Annotations

Check notice on line 63 in control/pid_longitudinal_controller/src/pid.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ New issue: Excess Number of Function Arguments 

PIDController::calculate has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis