Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_traffic_light_multi_camera_fusion): split utils and add test #10360

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MasatoSaeki
Copy link
Contributor

Description

Split file to perform the test and add unit test.

Related links

Parent Issue:

  • Link

How was this PR tested?

Evaluator

Unit Test

colcon build --merge-install --symlink-install --packages-up-to autoware_traffic_light_multi_camera_fusion --cmake-args -DCMAKE_BUILD_TYPE=Debug
colcon test --merge-install --packages-select autoware_traffic_light_multi_camera_fusion --event-handlers console_cohesion+

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

init

Verified

This commit was signed with the committer’s verified signature.
jplatte Jonas Platte
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
chore
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@MasatoSaeki MasatoSaeki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 27, 2025
pre-commit-ci bot and others added 2 commits March 27, 2025 09:25
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.

Project coverage is 25.67%. Comparing base (9b671b5) to head (b7ecbf6).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...on/src/traffic_light_multi_camera_fusion_utils.cpp 80.00% 6 Missing ⚠️
...ion/src/traffic_light_multi_camera_fusion_node.cpp 0.00% 3 Missing ⚠️
...on/src/traffic_light_multi_camera_fusion_utils.hpp 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10360      +/-   ##
==========================================
+ Coverage   25.64%   25.67%   +0.02%     
==========================================
  Files        1360     1362       +2     
  Lines      104750   104758       +8     
  Branches    39853    39915      +62     
==========================================
+ Hits        26868    26896      +28     
+ Misses      75271    75249      -22     
- Partials     2611     2613       +2     
Flag Coverage Δ *Carryforward flag
differential 2.47% <71.05%> (?)
differential-cuda 2.47% <71.05%> (?)
total 25.65% <ø> (+<0.01%) ⬆️ Carriedforward from 7f8b36f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant