Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manual control #10354

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Mar 27, 2025

Description

https://github.com/orgs/autowarefoundation/discussions/5369
For AD API manual control feature, use autoware_adapi_v1_msgs in external_cmd and vehicle_cmd nodes.
The default_adapi node enables or disables each topic depending on the requested mode.

Related links

Parent Issue:

How was this PR tested?

Use this tool and check if you can manually control the vehicle.
autowarefoundation/autoware_tools#229

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
done todo
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi isamu-takagi changed the title Feat/manual control feat: manual control Mar 27, 2025
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
fix test
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for control

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi requested a review from shmpwk March 31, 2025 04:45
@isamu-takagi isamu-takagi self-assigned this Mar 31, 2025
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 31, 2025
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 31.22172% with 152 lines in your changes missing coverage. Please review.

Project coverage is 25.33%. Comparing base (cb5f2aa) to head (d513047).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...stem/autoware_default_adapi/src/manual_control.cpp 31.37% 69 Missing and 1 partial ⚠️
...ternal_cmd_selector/external_cmd_selector_node.cpp 0.00% 52 Missing ⚠️
...are_default_adapi/src/utils/command_conversion.cpp 0.00% 15 Missing ⚠️
...hicle/autoware_external_cmd_converter/src/node.cpp 52.00% 11 Missing and 1 partial ⚠️
...autoware_vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 33.33% 1 Missing and 1 partial ⚠️
...ternal_cmd_selector/external_cmd_selector_node.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10354      +/-   ##
==========================================
+ Coverage   25.25%   25.33%   +0.07%     
==========================================
  Files        1329     1334       +5     
  Lines      103507   103654     +147     
  Branches    39180    39244      +64     
==========================================
+ Hits        26144    26259     +115     
- Misses      74850    74871      +21     
- Partials     2513     2524      +11     
Flag Coverage Δ *Carryforward flag
differential 18.60% <31.22%> (?)
total 25.24% <ø> (-0.02%) ⬇️ Carriedforward from cb5f2aa

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants