Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(voxel_based_compare_map): temporary fix pointcloud transform lookup #10299

Merge branch 'main' into fix/transform_lookup_time_compare_map

a729908
Select commit
Loading
Failed to load commit list.
Merged

fix(voxel_based_compare_map): temporary fix pointcloud transform lookup #10299

Merge branch 'main' into fix/transform_lookup_time_compare_map
a729908
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 25, 2025 in 39s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method, Complex Conditional)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
node.cpp 2 advisory rules 10.00 → 9.10 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional node.cpp: VoxelBasedCompareMapFilterComponent::convert_output_costly
  • Complex Method node.cpp: VoxelBasedCompareMapFilterComponent::convert_output_costly

Annotations

Check warning on line 178 in perception/autoware_compare_map_segmentation/src/voxel_based_compare_map_filter/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

VoxelBasedCompareMapFilterComponent::convert_output_costly has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 139 in perception/autoware_compare_map_segmentation/src/voxel_based_compare_map_filter/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

VoxelBasedCompareMapFilterComponent::convert_output_costly has 2 complex conditionals with 4 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.