-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port autoware_motion_velocity_planner_node to core #10293
base: main
Are you sure you want to change the base?
feat: port autoware_motion_velocity_planner_node to core #10293
Conversation
…to autoware_internal_metric_msgs Signed-off-by: suchang <chang.su@autocore.ai>
…tion_velocity_planner_node
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10293 +/- ##
==========================================
+ Coverage 26.04% 26.32% +0.27%
==========================================
Files 1375 1378 +3
Lines 106433 107019 +586
Branches 40872 41374 +502
==========================================
+ Hits 27725 28170 +445
- Misses 75710 76034 +324
+ Partials 2998 2815 -183
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Velocity Limit was fixed in #10273 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the package name should not be changed.
Otherwise the PR looks good.
planning/motion_velocity_planner/autoware_motion_velocity_planner_node_universe/CMakeLists.txt
Show resolved
Hide resolved
Great news mits san @mitsudome-r I will continue porting autoware_velocity_smoother ASAP Have a nice day! 心刚 |
Signed-off-by: suchang <chang.su@autocore.ai>
… github.com:storrrrrrrrm/autoware.universe into universe2core/autoware_motion_velocity_planner_node
Description
port autoware_motion_velocity_planner_node to core.
as @liuXinGangChina suggest, i create this pr here for migrate from universe to core with minimal changes.
this pr mainly modify tier4_metric_msgs to autoware_internal_metric_msgs. i do not do anything with tier4_planning_msgs::msg::VelocityLimit** because i am told that tier4 is working on this.
Related links
there is a pr here
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.