Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port autoware_motion_velocity_planner_node to core #10293

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

storrrrrrrrm
Copy link
Contributor

@storrrrrrrrm storrrrrrrrm commented Mar 18, 2025

Description

port autoware_motion_velocity_planner_node to core.

as @liuXinGangChina suggest, i create this pr here for migrate from universe to core with minimal changes.
this pr mainly modify tier4_metric_msgs to autoware_internal_metric_msgs. i do not do anything with tier4_planning_msgs::msg::VelocityLimit** because i am told that tier4 is working on this.

Related links

there is a pr here

Parent Issue:

  • Link

How was this PR tested?

  1. colcon build pass
  2. start simulator,plan a A point to B point path correctly

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

suchang and others added 2 commits March 13, 2025 17:43
…to autoware_internal_metric_msgs

Signed-off-by: suchang <chang.su@autocore.ai>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Mar 18, 2025
Copy link

github-actions bot commented Mar 18, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@storrrrrrrrm storrrrrrrrm added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) labels Mar 18, 2025
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.32%. Comparing base (837db39) to head (00b742a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10293      +/-   ##
==========================================
+ Coverage   26.04%   26.32%   +0.27%     
==========================================
  Files        1375     1378       +3     
  Lines      106433   107019     +586     
  Branches    40872    41374     +502     
==========================================
+ Hits        27725    28170     +445     
- Misses      75710    76034     +324     
+ Partials     2998     2815     -183     
Flag Coverage Δ *Carryforward flag
differential 6.80% <ø> (?)
total 26.37% <ø> (+0.32%) ⬆️ Carriedforward from 191858c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mitsudome-r
Copy link
Member

Velocity Limit was fixed in #10273

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the package name should not be changed.
Otherwise the PR looks good.

@liuXinGangChina
Copy link
Contributor

Velocity Limit was fixed in #10273

Great news mits san @mitsudome-r

I will continue porting autoware_velocity_smoother ASAP

Have a nice day!

心刚

suchang added 2 commits March 19, 2025 16:08
Signed-off-by: suchang <chang.su@autocore.ai>
… github.com:storrrrrrrrm/autoware.universe into universe2core/autoware_motion_velocity_planner_node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

4 participants