Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_multi_object_tracker): unknown object orientation #10286

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Mar 17, 2025

Description

Object shape process for polygon shape (generally for unknown object) should be processed after the object is transformed to world coordinate.
This PR fixes the previous PR the polygon process before the transform.

BUG

simplescreenrecorder-2025-03-17_19.57.42.mp4

Additionally, fix a bug to fit bounding box to the polygon.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…ncertainty modeling in input manager

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…imits and including min_z

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin self-assigned this Mar 17, 2025
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 17, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin changed the title fix(): unknown object orientation fix(autoware_multi_object_tracker): unknown object orientation Mar 17, 2025
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 17, 2025
@technolojin technolojin marked this pull request as ready for review March 17, 2025 10:54
@technolojin technolojin enabled auto-merge (squash) March 17, 2025 10:59
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 26.04%. Comparing base (e69b61d) to head (a64d444).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...e_multi_object_tracker/lib/object_model/shapes.cpp 0.00% 8 Missing ⚠️
...lti_object_tracker/src/processor/input_manager.cpp 0.00% 6 Missing ⚠️
...ject_tracker/lib/tracker/model/unknown_tracker.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10286      +/-   ##
==========================================
- Coverage   26.04%   26.04%   -0.01%     
==========================================
  Files        1375     1375              
  Lines      106439   106453      +14     
  Branches    40902    40905       +3     
==========================================
  Hits        27726    27726              
- Misses      76009    76023      +14     
  Partials     2704     2704              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 26.05% <ø> (+<0.01%) ⬆️ Carriedforward from e69b61d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit b3d15d9 into autowarefoundation:main Mar 18, 2025
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants