Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint): add diagnostics for processing time #10284

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Merge branch 'main' into mau/perception/lidar_centerpoint/add_diagnos…

d25757e
Select commit
Loading
Failed to load commit list.
Open

feat(lidar_centerpoint): add diagnostics for processing time #10284

Merge branch 'main' into mau/perception/lidar_centerpoint/add_diagnos…
d25757e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 28, 2025 in 49s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method, Large Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
node.cpp 2 advisory rules 9.22 → 9.04 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method node.cpp: LidarCenterPointNode::LidarCenterPointNode
  • Complex Method node.cpp: LidarCenterPointNode::pointCloudCallback

Annotations

Check warning on line 244 in perception/autoware_lidar_centerpoint/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

LidarCenterPointNode::pointCloudCallback increases in cyclomatic complexity from 9 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 144 in perception/autoware_lidar_centerpoint/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

LidarCenterPointNode::LidarCenterPointNode increases from 88 to 101 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.