Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_merger): add diagnostics warning for timeout when merging #10283

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

style(pre-commit): autofix

1bb30d4
Select commit
Loading
Failed to load commit list.
Open

feat(object_merger): add diagnostics warning for timeout when merging #10283

style(pre-commit): autofix
1bb30d4
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 17, 2025 in 33s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
object_association_merger_node.cpp 1 advisory rule 8.49 → 8.45 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method object_association_merger_node.cpp: ObjectAssociationMergerNode::objectsCallback

Annotations

Check warning on line 165 in perception/autoware_object_merger/src/object_association_merger_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

ObjectAssociationMergerNode::objectsCallback already has high cyclomatic complexity, and now it increases in Lines of Code from 93 to 103. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.