fix(autoware_crosswalk_traffic_light_estimator): add process that guard access to empty elements #10281
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard access to empty elements. Signed-off-by: k-hazama-esol <k-hazama@esol.co.jp>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: k-hazama-esol <k-hazama@esol.co.jp>
TomohitoAndo
changed the title
TomohitoAndo
added
the
run:build-and-test-differential
k-hazama-esol
force-pushed
the
fix/empty_access_guard_crosswalk_traffic_light_estimator
branch
from
9ac18bf to
8d208e7
Compare
k-hazama-esol
requested review from
MasatoSaeki,
satoshi-ota,
tzhong518 and
YoshiRi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10281 +/- ##
==========================================
- Coverage 26.06% 26.03% -0.03%
==========================================
Files 1376 1376
Lines 106574 106680 +106
Branches 40913 40961 +48
==========================================
Hits 27776 27776
- Misses 76087 76193 +106
Partials 2711 2711
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a problem that the crosswalk traffic light estimator drops out when a pedestrian signal is received with V2I signal coordination.
This problem is caused by a process in crosswalk_traffic_light_estimator that accesses elements without checking for the presence of signal recognition results.
Accessing an element without checking its value even when it is empty causes a segmentation fault.
This PR solves the problem by adding a process that prevents the result of signal recognition from being referenced in an empty state.
Related links
Private Links:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.