feat(autoware_pointcloud_preprocessor): update the readme file and schema file #10193
+30
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hema file Signed-off-by: vish0012 <vishalchhn42@gmail.com>
vish0012
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
vividf,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
vividf
added
the
run:deploy-docs
Signed-off-by: vish0012 <vishalchhn42@gmail.com>
|
https://autowarefoundation.github.io/autoware.universe/pr-10193/sensing/autoware_pointcloud_preprocessor/ shows "Macro Rendering Error", is that expected? |
github-actions
bot
added
the
component:perception
mojomex
requested changes
Mar 5, 2025
There was a problem hiding this comment.
Thank you for the PR! A few of the schemas seem to have the wrong structure at the bottom (ROS 2 is expecting a namespace like /** as the schema root). I added a few other minor comments too.
You can always check the rendered documentation here: https://autowarefoundation.github.io/autoware.universe/pr-10193/sensing/autoware_pointcloud_preprocessor/
sensing/autoware_pointcloud_preprocessor/schema/blockage_diag_node.schema.json
Show resolved
Hide resolved
...re_pointcloud_preprocessor/schema/pickup_based_voxel_grid_downsample_filter_node.schema.json
Outdated
Show resolved
Hide resolved
sensing/autoware_pointcloud_preprocessor/schema/passthrough_filter_uint16_node.schema.json
Outdated
Show resolved
Hide resolved
...re_pointcloud_preprocessor/schema/pickup_based_voxel_grid_downsample_filter_node.schema.json
Outdated
Show resolved
Hide resolved
Updated schema as directed. Changed 0 -> "0" and false -> "false"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_pointcloud_preprocessor package.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.