Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_radar_object_tracker): Add schema files and update readme file for autoware_radar_object_tracker #10038

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vish0012
Copy link
Contributor

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_radar_object_tracker package.

  • create json schema
  • update readme file

Related links

Parent Issue:

  • Link

How was this PR tested?

  • colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_radar_object_tracker

  • ros2 launch launch/rautoware_radar_object_tracker.launch.xml

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 20, 2025
@technolojin technolojin self-assigned this Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.82%. Comparing base (b795851) to head (6efd908).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10038      +/-   ##
==========================================
- Coverage   26.82%   26.82%   -0.01%     
==========================================
  Files        1415     1415              
  Lines      108305   108312       +7     
  Branches    41740    41741       +1     
==========================================
  Hits        29058    29058              
- Misses      76365    76372       +7     
  Partials     2882     2882              
Flag Coverage Δ *Carryforward flag
differential 0.44% <ø> (?)
differential-cuda 0.44% <ø> (?)
total 26.82% <ø> (ø) Carriedforward from b795851

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin
Copy link
Contributor

@vish0012
Can you

  • rebase it to latest main branch
  • pass the json schema check test

@vish0012 vish0012 force-pushed the add-schema-autoware_radar_object_tracker branch from 409e3d6 to ef6e1d5 Compare March 18, 2025 03:58
Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Signed-off-by: vish0012 <vishalchhn42@gmail.com>
@vish0012 vish0012 force-pushed the add-schema-autoware_radar_object_tracker branch from 9d83e2d to 2ebd95d Compare March 18, 2025 04:56
@vish0012
Copy link
Contributor Author

@vish0012 Can you

  • rebase it to latest main branch
  • pass the json schema check test

@technolojin thank you for your comments , i have updated as per your comments and check again, it work thank you, let me know if anything more needed.
Screenshot from 2025-03-18 13-54-41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants