feat(motion_velocity_smoother): add parameter for force acceleration #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
7 tasks
go-sakayori
requested review from
takayuki5168,
rej55,
satoshi-ota and
shmpwk
as code owners
Comment on lines
64
to
67
| # force acceleration | ||
| adjusted_max_acceleration: 2.0 | ||
| adjusted_max_jerk: 5.0 | ||
| adjusted_max_lateral_acceleration: 1.0 |
There was a problem hiding this comment.
Can you create a namespace as follows for the better readability?
These are used in other packages like obstacle_cruise_planner for example.
force_acceleration:
adjusted_max_acc: 2.0
adjusted_max_jerk: 5.0
...
There was a problem hiding this comment.
Thank you for the review. I modified it in commit ebb0187.
Used abbreviation based on your suggestion.
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
|
It would be closed one . Would make a PR once again after the functions are arranged in proper architecture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some parameter added to enable force acceleration.
Related PR: autowarefoundation/autoware_universe#7180
Tests performed
TIER IV interal evaluator + Psim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.