Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(query): add faster getLinkedParkingLot function #19

Merged

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jul 10, 2024

Description

Implement a more efficient getLinkedParkingLot that do not require providing ALL parking lots.
Instead an efficient query on the lanelet map is used.

Needed for autowarefoundation/autoware.universe#7930

Tests performed

Psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.84%. Comparing base (98b1edb) to head (aa3ce3c).

Files Patch % Lines
autoware_lanelet2_extension/lib/query.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   15.88%   15.84%   -0.05%     
==========================================
  Files          40       40              
  Lines        2758     2765       +7     
  Branches     1346     1348       +2     
==========================================
  Hits          438      438              
- Misses       2232     2239       +7     
  Partials       88       88              
Flag Coverage Δ *Carryforward flag
differential 15.84% <0.00%> (-0.91%) ⬇️
total 15.88% <ø> (ø) Carriedforward from 98b1edb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r merged commit 252aa1a into autowarefoundation:main Jul 10, 2024
15 of 19 checks passed
@maxime-clem maxime-clem deleted the perf/getLinkedParkingLot branch July 10, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants