perf(costmap_generator, scenario_selector): faster getLinkedParkingLot #7930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
kosuke55
as code owners
github-actions
bot
added
the
component:planning
4 tasks
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
maxime-clem
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7930 +/- ##
==========================================
- Coverage 28.74% 28.73% -0.01%
==========================================
Files 1593 1594 +1
Lines 116860 116883 +23
Branches 50023 50025 +2
==========================================
+ Hits 33586 33587 +1
- Misses 74148 74172 +24
+ Partials 9126 9124 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Jul 22, 2024
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 23, 2024
autowarefoundation#7930) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jul 23, 2024
autowarefoundation#7930) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
autowarefoundation#7930) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the improved
getLinkedParkingLot()function so that it does not requiring providing ALL parking lots lanelets.Related links
How was this PR tested?
Psim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.