-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port simplified version of autoware_mission_planner from Autoware Universe #329
feat: port simplified version of autoware_mission_planner from Autoware Universe #329
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
d5a44ad
to
e24db9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetic feedback only. So LGTM
planning/autoware_mission_planner/test/test_lanelet2_plugins_default_planner.cpp
Outdated
Show resolved
Hide resolved
planning/autoware_mission_planner/test/test_utility_functions.cpp
Outdated
Show resolved
Hide resolved
Since this PR is not porting, I enable auto-merge. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
===========================================
- Coverage 78.75% 11.82% -66.94%
===========================================
Files 11 51 +40
Lines 193 3790 +3597
Branches 73 821 +748
===========================================
+ Hits 152 448 +296
- Misses 11 3267 +3256
- Partials 30 75 +45
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Resolved #265
This ports the autoware_mission_planner_universe into Autoware Core while removing the unnecessary functionality for Autoware Core. The removing functionality are related to MRM design, which are still subject to change.
Specifically, the following modification are made:
Note that we will keep the original autoware_mission_planner_universe in Autoware Universe for people who wish to continue using the advanced features.
Related links
Parent Issue:
How was this PR tested?
I have tested locally using AWSIM that it can calculate the path from
ros2 service call /planning/mission_planner/set_waypoint_route autoware_internal_planning_msgs/srv/SetWaypointRoute
commandNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.