Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port simplified version of autoware_mission_planner from Autoware Universe #329

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Mar 27, 2025

Description

Resolved #265

This ports the autoware_mission_planner_universe into Autoware Core while removing the unnecessary functionality for Autoware Core. The removing functionality are related to MRM design, which are still subject to change.

Specifically, the following modification are made:

  • Removing route selector functionality since we don't support MRM
  • Removing reroute_availability and modified_goal interface from behavior_path_planner since we do not port behavior_path_planner in Phase 1.
  • replace tier4_planning_msgs with autoware_internal_planning_msgs

Note that we will keep the original autoware_mission_planner_universe in Autoware Universe for people who wish to continue using the advanced features.

Related links

Parent Issue:

How was this PR tested?

I have tested locally using AWSIM that it can calculate the path from ros2 service call /planning/mission_planner/set_waypoint_route autoware_internal_planning_msgs/srv/SetWaypointRoute command

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@mitsudome-r mitsudome-r requested review from takayuki5168 and a team March 27, 2025 10:18
Copy link

github-actions bot commented Mar 27, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

mitsudome-r and others added 10 commits March 27, 2025 20:35
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the port-autoware_mission_planner branch from d5a44ad to e24db9e Compare March 27, 2025 11:35
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic feedback only. So LGTM

@youtalk youtalk enabled auto-merge (squash) March 27, 2025 12:04
@youtalk
Copy link
Member

youtalk commented Mar 27, 2025

Since this PR is not porting, I enable auto-merge.

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 31.87184% with 404 lines in your changes missing coverage. Please review.

Project coverage is 11.82%. Comparing base (4cb18f5) to head (800a26d).
Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
...on_planner/src/mission_planner/mission_planner.cpp 0.00% 304 Missing ⚠️
...n_planner/src/lanelet2_plugins/default_planner.cpp 75.53% 29 Missing and 17 partials ⚠️
...on_planner/src/mission_planner/arrival_checker.cpp 0.00% 19 Missing ⚠️
.../src/goal_pose_visualizer/goal_pose_visualizer.cpp 0.00% 13 Missing ⚠️
...sion_planner/src/mission_planner/service_utils.hpp 0.00% 13 Missing ⚠️
...planner/src/lanelet2_plugins/utility_functions.cpp 90.19% 2 Missing and 3 partials ⚠️
...sion_planner/src/mission_planner/service_utils.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #329       +/-   ##
===========================================
- Coverage   78.75%   11.82%   -66.94%     
===========================================
  Files          11       51       +40     
  Lines         193     3790     +3597     
  Branches       73      821      +748     
===========================================
+ Hits          152      448      +296     
- Misses         11     3267     +3256     
- Partials       30       75       +45     
Flag Coverage Δ
differential 11.82% <31.87%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@youtalk youtalk merged commit 2b4233a into autowarefoundation:main Mar 27, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Development

Successfully merging this pull request may close these issues.

Implement simpler version of mission_planner
3 participants