Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoware_objects_of_interest_marker_interface): porting from universe to core #9931

Merged
merged 2 commits into from
Feb 21, 2025
Merged

feat(autoware_objects_of_interest_marker_interface): porting from universe to core #9931

merged 2 commits into from
Feb 21, 2025

Conversation

liuXinGangChina
Copy link
Contributor

Description

We are porting autoware_objects_of_interest_marker_interface to autoware.core, and this PR remove the package from universe

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@liuXinGangChina liuXinGangChina self-assigned this Jan 16, 2025
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 16, 2025
@liuXinGangChina liuXinGangChina removed the type:documentation Creating or refining documentation. (auto-assigned) label Jan 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@liuXinGangChina liuXinGangChina added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 16, 2025
@liuXinGangChina liuXinGangChina mentioned this pull request Jan 16, 2025
Merged
youtalk
youtalk approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

youtalk
youtalk requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve the merge conflicts and apply the fixes to autowarefoundation/autoware.core#168 as well.

@liuXinGangChina liuXinGangChina force-pushed the obj-marker-interface-migration branch from 6a04297 to fcc6f7a Compare February 15, 2025 07:29
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Feb 15, 2025
@liuXinGangChina
Copy link
Contributor Author

We need to resolve the merge conflicts and apply the fixes to autowarefoundation/autoware.core#168 as well.

Mits san and Kondo san, @mitsudome-r @youtalk

Sorry to bother you on weekend,
I have resolved the conflict with main branch

I checked that modification under universe repo is only about package.xml and CHANGELOG.rst, no need to update the prunder core repo.

图片

Have a nice weekend!

心刚

youtalk
youtalk approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuXinGangChina
feat(autoware_objects_of_interest_marker_interface): porting from uni…
ceb78cd 
…verse to core, remove package from universe repo: v0.0

Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>
@liuXinGangChina liuXinGangChina force-pushed the obj-marker-interface-migration branch from fcc6f7a to ceb78cd Compare February 19, 2025 02:22
@mitsudome-r mitsudome-r mentioned this pull request Feb 20, 2025
Merged
@mitsudome-r
Copy link
Member

Waiting for: #10174

@liuXinGangChina
Copy link
Contributor Author

sorry for the dependency issue

will rebase this pr after pr-10174 merged

Best regards

心刚

Waiting for: #10174

@mitsudome-r
Merge remote-tracking branch 'origin/main' into obj-marker-interface-…
dc1cb64 
…migration

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r merged commit f976968 into autowarefoundation:main Feb 21, 2025
26 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtalk youtalk youtalk approved these changes

@rej55 rej55 Awaiting requested review from rej55

@kosuke55 kosuke55 Awaiting requested review from kosuke55

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

Assignees

@liuXinGangChina liuXinGangChina

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuXinGangChina @mitsudome-r @youtalk