feat(autoware_objects_of_interest_marker_interface): porting from universe to core #168

liuXinGangChina · 2025-01-15T09:58:13Z

We are porting autoware_objects_of_interest_marker_interface to autoware.core, and this PR add the package to core

Description

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…verse to core, autoware_objects_of_interest_marker_interface, add this package to core repo and replace universe_utils dependency with autoware_utils dependency: v0.0 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>

github-actions · 2025-01-15T09:58:24Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

…verse to core, autoware_objects_of_interest_marker_interface, fix readme spell issue: v0.1 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>

…verse to core, autoware_objects_of_interest_marker_interface, update due to the function name change of autoware_utils: v0.2 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>

mitsudome-r · 2025-01-21T15:12:50Z

The modification seems okay, but this must be merged after autowarefoundation/autoware_utils#23

youtalk

I think adding autoware_utils to build_depends.repos will make the CI pass. Other than that, LGTM.

liuXinGangChina · 2025-01-24T05:59:09Z

I think adding autoware_utils to build_depends.repos will make the CI pass. Other than that, LGTM.

That‘s right Kondo san @youtalk ，and we do that in this pr。
once pr-149 merged we will rebase this pr for merging

Best regrads

心刚

youtalk · 2025-01-29T07:01:11Z

@liuXinGangChina #149 will take some time to merge, so we would like to merge this PR first since it has no external dependencies.

#168 (review)

I think adding autoware_utils to build_depends.repos will make the CI pass. Other than that, LGTM.

…migration rebase with main branch

…verse to core, autoware_objects_of_interest_marker_interface, add autoware_utils to build.depends, along with internal_msgs which needed by pr-149: v0.2 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>

codecov · 2025-02-08T01:52:26Z

Codecov Report

Attention: Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.

Project coverage is 53.52%. Comparing base (4cb18f5) to head (dae9362).
Report is 40 commits behind head on main.

Files with missing lines	Patch %	Lines
..._of_interest_marker_interface/src/marker_utils.cpp	0.00%	45 Missing ⚠️
...rface/src/objects_of_interest_marker_interface.cpp	0.00%	35 Missing ⚠️
...ects_of_interest_marker_interface/src/coloring.cpp	0.00%	8 Missing ⚠️
...interface/objects_of_interest_marker_interface.hpp	0.00%	2 Missing ⚠️
...jects_of_interest_marker_interface/marker_data.hpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #168       +/-   ##
===========================================
- Coverage   78.75%   53.52%   -25.24%     
===========================================
  Files          11       16        +5     
  Lines         193      284       +91     
  Branches       73       75        +2     
===========================================
  Hits          152      152               
- Misses         11      102       +91     
  Partials       30       30

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`78.75% <ø> (ø)`		Carriedforward from 4cb18f5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

liuXinGangChina · 2025-02-08T02:02:57Z

@liuXinGangChina #149 will take some time to merge, so we would like to merge this PR first since it has no external dependencies.

#168 (review)

I think adding autoware_utils to build_depends.repos will make the CI pass. Other than that, LGTM.

Kondo san @youtalk

I have add those build depend to the file according to your comment

Have a nice day

心刚

youtalk

LGTM

mitsudome-r · 2025-02-13T08:03:40Z

@liuXinGangChina Could you resolve the conflicts that is occurring on the PR for Universe? autowarefoundation/autoware.universe#9931

liuXinGangChina · 2025-02-14T09:55:44Z

@liuXinGangChina Could you resolve the conflicts that is occurring on the PR for Universe? autowarefoundation/autoware.universe#9931

Sure mits san

liuXinGangChina · 2025-02-15T07:42:08Z

@liuXinGangChina Could you resolve the conflicts that is occurring on the PR for Universe? autowarefoundation/autoware.universe#9931

Sure mits san

Mits san and Kondo san, @mitsudome-r @youtalk

Sorry to bother you on weekend,
I have resolved the conflict with main branch under universe repo in this pr

I checked that modification under universe repo is only about package.xml and CHANGELOG.rst, no need to update this pr under core repo.

Have a nice weekend!

心刚

liuXinGangChina mentioned this pull request Jan 15, 2025

Port 'autoware_vehicle_info_utils' and 'autoware_universe_utils' from Autoware Universe to Autoware Core #131

Open

25 tasks

liuXinGangChina self-assigned this Jan 15, 2025

liuXinGangChina added component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jan 15, 2025

feat(autoware_objects_of_interest_marker_interface): porting from uni…

a145d20

…verse to core, autoware_objects_of_interest_marker_interface, fix readme spell issue: v0.1 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>

liuXinGangChina force-pushed the obj-marker-interface-migration branch from dc55091 to a145d20 Compare January 15, 2025 10:03

feat(autoware_objects_of_interest_marker_interface): porting from uni…

211b164

…verse to core, autoware_objects_of_interest_marker_interface, update due to the function name change of autoware_utils: v0.2 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>

liuXinGangChina force-pushed the obj-marker-interface-migration branch from 5f363bf to 211b164 Compare January 16, 2025 02:53

liuXinGangChina mentioned this pull request Jan 16, 2025

feat(autoware_objects_of_interest_marker_interface): porting from universe to core autowarefoundation/autoware.universe#9931

Merged

liuXinGangChina requested a review from mitsudome-r January 16, 2025 03:06

youtalk reviewed Jan 24, 2025

View reviewed changes

liuXinGangChina added 2 commits February 8, 2025 09:32

Merge remote-tracking branch 'origin/main' into obj-marker-interface-…

8acc7ab

…migration rebase with main branch

feat(autoware_objects_of_interest_marker_interface): porting from uni…

79b2532

…verse to core, autoware_objects_of_interest_marker_interface, add autoware_utils to build.depends, along with internal_msgs which needed by pr-149: v0.2 Signed-off-by: liuXinGangChina <lxg19892021@gmail.com>

liuXinGangChina force-pushed the obj-marker-interface-migration branch from 1b07724 to 79b2532 Compare February 8, 2025 01:45

style(pre-commit): autofix

dae9362

liuXinGangChina requested a review from youtalk February 8, 2025 02:01

youtalk approved these changes Feb 10, 2025

View reviewed changes

mitsudome-r mentioned this pull request Feb 20, 2025

feat(autoware_objects_of_interest_marker_interface): replace autoware_universe_utils with autoware_utils autowarefoundation/autoware.universe#10174

Merged

mitsudome-r merged commit 1f47238 into main Feb 21, 2025
24 of 27 checks passed

mitsudome-r deleted the obj-marker-interface-migration branch February 21, 2025 01:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(autoware_objects_of_interest_marker_interface): porting from universe to core #168

feat(autoware_objects_of_interest_marker_interface): porting from universe to core #168

liuXinGangChina commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

mitsudome-r commented Jan 21, 2025

youtalk left a comment

liuXinGangChina commented Jan 24, 2025 •

edited

Loading

youtalk commented Jan 29, 2025

codecov bot commented Feb 8, 2025 •

edited

Loading

liuXinGangChina commented Feb 8, 2025

youtalk left a comment

mitsudome-r commented Feb 13, 2025

liuXinGangChina commented Feb 14, 2025

liuXinGangChina commented Feb 15, 2025

feat(autoware_objects_of_interest_marker_interface): porting from universe to core #168

feat(autoware_objects_of_interest_marker_interface): porting from universe to core #168

Conversation

liuXinGangChina commented Jan 15, 2025 • edited Loading

Description

Related links

How was this PR tested?

Notes for reviewers

Interface changes

Effects on system behavior

github-actions bot commented Jan 15, 2025 • edited Loading

mitsudome-r commented Jan 21, 2025

youtalk left a comment

Choose a reason for hiding this comment

liuXinGangChina commented Jan 24, 2025 • edited Loading

youtalk commented Jan 29, 2025

codecov bot commented Feb 8, 2025 • edited Loading

Codecov Report

liuXinGangChina commented Feb 8, 2025

youtalk left a comment

Choose a reason for hiding this comment

mitsudome-r commented Feb 13, 2025

liuXinGangChina commented Feb 14, 2025

liuXinGangChina commented Feb 15, 2025

liuXinGangChina commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

liuXinGangChina commented Jan 24, 2025 •

edited

Loading

codecov bot commented Feb 8, 2025 •

edited

Loading